You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you take almost any preprocessed shader from https://github.com/ConfettiFX/The-Forge you won't be able to compile it with -gVS option. Reproduction steps:
Apply this patch to avoid python warning and get error message: glslang_gVS.patch
set FSL_COMPILER_VK env variable to the folder that contains desired glslangValidator executable (e.g. $env:FSL_COMPILER_VK="C:\VulkanSDK\1.3.268.0\Bin\" in powershell)
Run from the root of the git repository py.exe .\Common_3\Tools\ForgeShadingLanguage\fsl.py --compile -b CompiledShaders -d PreprocessedShaders -l VULKAN --debug .\Examples_3\Unit_Tests\src\01_Transformations\Shaders\FSL\ShaderList.fsl
Converted GLSL from FSL will be in PreprocessedShader/VULKAN folder, compiled SPIR-V will be in CompiledShaders/VULKAN folder
You can try the same with any file named ShaderList.fsl inside Examples_3 folder
You can compiler them with the following command: glslangValidator.exe -D_DEBUG -gVS -V PreprocessedShaders/VULKAN/skybox.vert -o CompiledShaders/VULKAN/skybox.vert_0.spv -IPath\To\The-Forge\Common_3\Tools\ForgeShadingLanguage -S vert --target-env spirv1.3 -DVK_EXT_DESCRIPTOR_INDEXING_ENABLED=0 -DVK_FEATURE_TEXTURE_ARRAY_DYNAMIC_INDEXING_ENABLED=0
I can preprocess entire The-Forge for you if you're going to fix this annoying issue. Debugging SPIR-V is okay but I prefer to look at GLSL code.
The text was updated successfully, but these errors were encountered:
Thanks, I can indeed reproduce this issue. Preliminarily I think the issue is with how #line directives are handled in preprocessed code and how that corresponds to OpDebugSource opcodes. This is definitely something that should be fixed.
If you take almost any preprocessed shader from https://github.com/ConfettiFX/The-Forge you won't be able to compile it with -gVS option. Reproduction steps:
FSL_COMPILER_VK
env variable to the folder that contains desired glslangValidator executable (e.g.$env:FSL_COMPILER_VK="C:\VulkanSDK\1.3.268.0\Bin\"
in powershell)py.exe .\Common_3\Tools\ForgeShadingLanguage\fsl.py --compile -b CompiledShaders -d PreprocessedShaders -l VULKAN --debug .\Examples_3\Unit_Tests\src\01_Transformations\Shaders\FSL\ShaderList.fsl
If you're a bit lazy to follow all the steps:
glslangValidator.exe -D_DEBUG -gVS -V PreprocessedShaders/VULKAN/skybox.vert -o CompiledShaders/VULKAN/skybox.vert_0.spv -IPath\To\The-Forge\Common_3\Tools\ForgeShadingLanguage -S vert --target-env spirv1.3 -DVK_EXT_DESCRIPTOR_INDEXING_ENABLED=0 -DVK_FEATURE_TEXTURE_ARRAY_DYNAMIC_INDEXING_ENABLED=0
I can preprocess entire The-Forge for you if you're going to fix this annoying issue. Debugging SPIR-V is okay but I prefer to look at GLSL code.
The text was updated successfully, but these errors were encountered: