Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

adding new footprints + swapping A/K pins #6

Merged
merged 18 commits into from
Apr 24, 2015
Merged

Conversation

odurc
Copy link
Collaborator

@odurc odurc commented Feb 27, 2015

The footprint looks like this:
screenshot_2015-02-27_08-05-14

I don't know if is ok put the diode symbol in the center, but I think it makes clear the cathode and anode.

@michal777
Copy link
Collaborator

There is a problem with pins numbering - you used the standard numbering but other diodes in kicad library use pin 1 for anode. I think that it's safer to keep one numbering in kicad libraries.
EDIT:
Longer line should indicate pin 1.

@odurc
Copy link
Collaborator Author

odurc commented Feb 27, 2015

Following this PDF (http://goo.gl/zbiU5M) that you've posted the cathode is the pin with longer line and it should be the pin 1, right?
KiCad uses anode as pin 1 and following KLC pin 1 shoud sit on left.
If I follow the PDF does it means that I'll have to solder the part in reverse way?

@michal777
Copy link
Collaborator

Longer line indicates pin 1. Pin 1 should be cathode but in kicad library it's anode so maybe anode should have longer line but it will be opposite to some ipc standards...
Maybe it's better to change all diodes in kicad library to have the standard numbering.
I think we will need to wait for opinions of other librarians.

@CarlPoirier
Copy link
Collaborator

Hi,

Yes, it indeed will be better to flip them all. In fact, they need to be redesigned. Ricardo, do you want to undertake this? Your symbol at the top is good, the only thing I'd say is maybe shorten the silkscreen lines a tiny bit to have a little bit of spacing between them and the courtyard.

@odurc
Copy link
Collaborator Author

odurc commented Mar 16, 2015

Sure, I can do it. I'm with tight time, but I'll do it ASAP. Just to be sure about the task, it is redesign the footprints of all diode and inverse all diodes pins numbers, of all schematic libraries, right?

@odurc
Copy link
Collaborator Author

odurc commented Apr 20, 2015

The diodes symbols also had A/K swaped at symbols KiCad/kicad-library#175.

@odurc odurc mentioned this pull request Apr 21, 2015
@odurc odurc changed the title adding SOD-123 adding new footprints + swapping A/K pins Apr 22, 2015
@CarlPoirier
Copy link
Collaborator

Hi Ricardo,

You will need to rotate the 3D packages for Diode_SMA_Standard and Diode_SMC_Standard. Besides that, I think it's good to go!

@CarlPoirier
Copy link
Collaborator

Awesome!! Thanks Ricardo.

CarlPoirier added a commit that referenced this pull request Apr 24, 2015
adding new footprints + swapping A/K pins
@CarlPoirier CarlPoirier merged commit 6858e5b into KiCad:master Apr 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants