Fixed a couple of KLC violations for SSOP footprints #12
Conversation
bump |
@pointhi @diggit @ashtonchase anyone want to check this one out? It's been here for a while now... |
All package outlines have now been added to the F.Fab layer |
Fixed pin-1 silkscreen indicator as per #15 |
as said in another PR before, please add pin 1 markers on the F.Fab layer. |
@CarlPoirier do you want the bevelled edge or happy with the circle? |
I prefer the bevelled edge. It looks more streamlined to me. |
Ok I shall revert the most recent commit and update. We really need to be putting all these little conventions together into a more detailed document to outline requirements for "good" footprints. |
Any preferences between the following two examples @CarlPoirier or @pointhi ? :) |
I do like the first one as we still get to see the real shape! |
I agree with @CarlPoirier, the first one |
Oliver, wait before proceeding. We are in discussion on the IRC channel. Join us if you wish! |
Oliver, we're onto something. Our suggestion is to use the same pin one marker as on the actual chip.This along with the outline would become a new KLC rule and apply to all footprints. What do you think? Edit: Thank you for the few iterations you did and sorry for generating more work for your pull request. |
So does this mean we are back to the small circle in the top-left corner? I'm happy with this or with the Option A as shown above. If it's the small circle option we want to go with I can un-revert the commit and all is done! |
Also I was not even aware of the IRC channel! Have joined now so I'll hang out there in future when I'm working on KiCad stuff |
Yeah that would be the circle. |
Ok, then no work needed on this PR! LMK if you need any more changes before accepting. |
Thank you Oliver, this is a great contribution. |
Fixes KLC 6.4 fot TSSOP-44
Fixes KLC 10.4 for MSOP-16