Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

Fixed a couple of KLC violations for SSOP footprints #12

Merged
merged 7 commits into from Aug 15, 2016
Merged

Fixed a couple of KLC violations for SSOP footprints #12

merged 7 commits into from Aug 15, 2016

Conversation

SchrodingersGat
Copy link
Contributor

@SchrodingersGat SchrodingersGat commented Feb 21, 2016

Fixes KLC 6.4 fot TSSOP-44
Fixes KLC 10.4 for MSOP-16

@SchrodingersGat
Copy link
Contributor Author

bump

@SchrodingersGat
Copy link
Contributor Author

@pointhi @diggit @ashtonchase anyone want to check this one out? It's been here for a while now...

@SchrodingersGat
Copy link
Contributor Author

All package outlines have now been added to the F.Fab layer

@SchrodingersGat
Copy link
Contributor Author

Fixed pin-1 silkscreen indicator as per #15

@pointhi
Copy link
Collaborator

pointhi commented Aug 14, 2016

as said in another PR before, please add pin 1 markers on the F.Fab layer.

@CarlPoirier
Copy link
Collaborator

This chould be a good example:
image

Besides that, it's awesome!

@SchrodingersGat
Copy link
Contributor Author

@CarlPoirier do you want the bevelled edge or happy with the circle?

@CarlPoirier
Copy link
Collaborator

I prefer the bevelled edge. It looks more streamlined to me.

@SchrodingersGat
Copy link
Contributor Author

Ok I shall revert the most recent commit and update. We really need to be putting all these little conventions together into a more detailed document to outline requirements for "good" footprints.

@SchrodingersGat
Copy link
Contributor Author

Any preferences between the following two examples @CarlPoirier or @pointhi ? :)

Option A
a

Option B
b

@CarlPoirier
Copy link
Collaborator

I do like the first one as we still get to see the real shape!

@pointhi
Copy link
Collaborator

pointhi commented Aug 14, 2016

I agree with @CarlPoirier, the first one

@CarlPoirier
Copy link
Collaborator

Oliver, wait before proceeding. We are in discussion on the IRC channel. Join us if you wish!

@CarlPoirier
Copy link
Collaborator

CarlPoirier commented Aug 14, 2016

Oliver, we're onto something. Our suggestion is to use the same pin one marker as on the actual chip.This along with the outline would become a new KLC rule and apply to all footprints. What do you think?

Edit: Thank you for the few iterations you did and sorry for generating more work for your pull request.

@SchrodingersGat
Copy link
Contributor Author

Our suggestion is to use the same pin one marker as on the actual chip.

So does this mean we are back to the small circle in the top-left corner? I'm happy with this or with the Option A as shown above. If it's the small circle option we want to go with I can un-revert the commit and all is done!

@SchrodingersGat
Copy link
Contributor Author

Also I was not even aware of the IRC channel! Have joined now so I'll hang out there in future when I'm working on KiCad stuff

@CarlPoirier
Copy link
Collaborator

Yeah that would be the circle.

@SchrodingersGat
Copy link
Contributor Author

Ok, then no work needed on this PR! LMK if you need any more changes before accepting.

@CarlPoirier
Copy link
Collaborator

Thank you Oliver, this is a great contribution.

@CarlPoirier CarlPoirier merged commit 2933ce3 into KiCad:master Aug 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants