Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

Create LED_RGB_5050-6.kicad_mod #35

Merged
merged 3 commits into from May 13, 2017
Merged

Conversation

JoanTheSpark
Copy link
Contributor

regarding this forum post on KiCAD.info:
https://forum.kicad.info/t/smd-rgb-led-footprint-5050/653?u=joan_sparky

took PLCC-6 footprint as template for line thicknesses/etc.

regarding this forum post on KiCAD.info:
https://forum.kicad.info/t/smd-rgb-led-footprint-5050/653?u=joan_sparky

took PLCC-6 footprint as template for line thicknesses/etc.
@jkriege2
Copy link
Collaborator

Hi!

thanks for the contribution. I just had a look at it. Could you please change some things to conform to our KLC-libtrary standards and some measurement errors?

  1. There should be a text-label %R on the F.Fab layer, typically centered in the symbol (i.e. at 0,0). You can make the font smaller to fit it inside. It serves as a second REFDES-label on F.Fab
  2. According to the DS (http://dlnmh9ip6v2uc.cloudfront.net/datasheets/Components/LED/5060BRG4.pdf), the package is 5mm wide and 6mm height, but yours is only 5mm high. Please fix.
  3. The courtyard clearance left and right is only 0.2mm, ut should be 0.25mm
  4. the pads 1,2,3,4,5,6 should be at y=1.7mm, but yours are at y=2mm. Please fix.
  5. Please add a 3D model link (even though the model does not yet exist, so it is used, when someone conributes or has a model). The link should be: ${KISYS3DMOD}/LEDs.3dshapes/LED_RGB_5050-6.wrl
  6. Finally please add a the datasheet URL to the description field

Best,
JAN

PS: Please (in future) ideally add a screenshot and a datasheet link to the PR, as this makes review easier/quicker. Also note that we have a continuous integration system now that checks for some KLC-violations in your symbols:
2017-05-12 07_32_23- 1 create led_rgb_5050-6 kicad_mod by joanthespark pull request 35 kicad_l

changed everything to make it KLC 2.0 compliant and added missing items
@JoanTheSpark
Copy link
Contributor Author

Thx for the pointers and again sorry for the wild PR.. was my first.

@jkriege2
Copy link
Collaborator

Hi!

great work!

One last request, would you add a circle to F.Fab, indicating the window of the LED? This way the footprint is in line with e.g.
2017-05-12 22_29_22-library browser leds c__development_kicad_share_kicad_modules_leds pretty

Best,
JAN

Added ring on F.Fab to depict optical window.
@JoanTheSpark
Copy link
Contributor Author

Done.

@jkriege2
Copy link
Collaborator

great work!
JAN

@jkriege2 jkriege2 merged commit 780fb5c into KiCad:master May 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants