-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Please address errors as per the Travis checks.
|
Also you can open the file in a text editor and change the offending lines to "Edge.Cuts" and that will work. |
Another option is to add text to the user comments layer saying "PCB cutout" or similar |
@myfreescalewebpage Will you be able to make the changes mentioned above so this PR can be merged? |
@evanshultz yes sorry I'm late on many PR at this moment but will do my best to fix them in coming days/weeks. Thanks for your review. |
Still violating 8.2 because anchor is kept on pin 1 for chip pro module. Datasheet of the manufacturer all reference to pin 1 so I think it's better like that isn't it ? |
@myfreescalewebpage I was just chasing old PRs. @jkriege2 @SchrodingersGat You guys reviewed this or the referenced PR. Would you be able to do this one? |
@jkriege2 for the first remark, how to to it easily ? All the dimensions are referenced to the pin 1 and the dimension of the module are not standard, review an d possible modifications will just be impossible after moving the anchor (today all dimensions are referenced to pin 1) |
@jkriege2 Modifications of silkscreen done. However, for the anchor of the CHIPPRO module, I think it is definitively better to keep it on pin 1. And in any case I don't know how to move to the center of the footprint, which is not "attached" to something "real" on the drawing. This need to compute the position of everything on the drawing from the center of the module.... |
Hi @myfreescalewebpage lets' see if we can't get this merged.
Other than that, looks good to me :) |
In preparation for the Kicad v5 release this repo is archived. |
Add CHIP and CHIP-PRO footprints following KiCad/kicad-library#654.
The internal silkscreen of CHIP-PRO should be a egde cut because the PCB need to be removed below the module. However, Edge Cuts is not available in the footprint editor.... See following screenshot and following photo of the CHIP-PRO dev kit which illustrate that (CHIP-PRO is black, PCB is white).