Skip to content
This repository has been archived by the owner on Nov 21, 2017. It is now read-only.

Fix KLC rules #13

Merged
merged 6 commits into from Jan 20, 2017
Merged

Fix KLC rules #13

merged 6 commits into from Jan 20, 2017

Conversation

Roman3349
Copy link
Contributor

@Roman3349 Roman3349 commented Dec 12, 2016

No description provided.

Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
@jkriege2
Copy link
Collaborator

Hi!

nice addition/fix. I also added a PR to rename the 3D parts lib accordingly (which we can also merge when this is done): KiCad/kicad-library#858

Since you're currently at it. Could you please also add the missing F.Fab-layer to some of the footprints?

Thanks,
JAN

@jkriege2
Copy link
Collaborator

Also we now updates the KLC to require a 0.12mm thick silkscreen ... could you also change that (although we can do that in a second PR).
... and there are some keywords separated by , not space ... if you have time, could you fix that?

Thank you very much!
JAN

Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
@Roman3349 Roman3349 changed the title Fix KLC rules 6.6 and 10.7 Fix KLC rules 6.5, 6.6, 10.3 and 10.7 Dec 20, 2016
@Roman3349 Roman3349 changed the title Fix KLC rules 6.5, 6.6, 10.3 and 10.7 Fix KLC rules Dec 20, 2016
Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
@Roman3349
Copy link
Contributor Author

Hi!

next week I am going to add the missing F.Fab-layer to some of the footprints.

Fixed rules:

  • 6.5 - fixed a 0.12mm thick silkscreen
  • 6.6 - added a 0.05mm thick courtyard
  • 6.9 - fixed a 0.10mm thick fabrication layer
  • 10.3 - remove comas from keywords
  • 10.8 - fixed name of directory for 3D shape

@jkriege2
Copy link
Collaborator

Very nice! Let me know when I should have a second look!
JAN

@Roman3349
Copy link
Contributor Author

@jkriege2 Sorry, I haven't got a time for adding the missing F.Fab-layer to some of the footprints. Please merge this pull request without it.

@jkriege2
Copy link
Collaborator

can do, but please rename the 3dshapes directory back to Relays_ThroughHole.3dshapes ... that#s technically a violation, but currently the models reside there ...

JAN

Signed-off-by: Roman3349 <ondracek.roman@centrum.cz>
@Roman3349
Copy link
Contributor Author

@jkriege2 Done.

@jkriege2
Copy link
Collaborator

Thanks!
JAN

@jkriege2 jkriege2 merged commit f31c7cf into KiCad:master Jan 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants