-
Notifications
You must be signed in to change notification settings - Fork 715
Moving several of the remainning footprints from connectors.pretty #111
Moving several of the remainning footprints from connectors.pretty #111
Conversation
jkriege2
commented
Nov 26, 2017
•
edited
Loading
edited
- with several KLC-fixes and moderinzations ...
- many still remain (see https://github.com/KiCad/kicad-footprints/blob/master/TODO.md)
- move of some 3D models: moved single pins to new location kicad-packages3D-source#67, moved single pins to new location kicad-packages3D#165
- one family is moved here: added fixed, pre-existing footprints for CPU-Fan headers #110
- remaining KL-errors are due to over-checking virtual components: This should be fixed by fix rule F5.2 for virtual components kicad-library-utils#182
Is it on purpose that this deletes 3 footprints from Conn_Card? |
They were not deleted, but renamed (added the Prefix JAN |
That's a very long prefix. In KiCad/kicad-library#1447 (comment) i suggested:
|
Hhmmm ...
Then we would e.g. get JAN |
Also: having normal-sized as normal would lead to Best, |
Jan the word "normal" would not actually appear in the footprint names. So it would appear as I agree with Rene that your longer names are too wordy - we had this discussion in particular at length for the new KLC - http://kicad-pcb.org/libraries/klc/F3.6/ Further notes:
|
Good Morning ;-p
Anything else? Note that this PR does not move ALL connectors, as for some I have no clue on where to put the, but the remainder should finally be handled in a separate PR (volunteer???) Best, PS: Just for info: I'm also currently working on a remake of the different types of TO-92 3D models and will also rework naming and footprints ... give me a few more days on that ;-) |
I agree that |
Hi!
Can be merged now? |
Two of the three barrel jack footprints are missing at least one pin 1 marker We can merge as is and document my remarks above in an issue if you want. |
Hi! I fixed everything except the solder jumpers. I'm planning to rework that lib at some point (but not today). So can it be merged for now? Best, |
PS: Should I still rename the BNC_Vertical? Ideas for a good name? @SchrodingersGat ? |
For the BNC Vertical, it would be a good idea to have a bit more information in the description field. One example part number might be a good start. (user can then go from there.) |
…to add_remainning_from_connectorspretty # Conflicts: # Conn_Card.pretty/microSD_HC_Wurth_693072010801.kicad_mod # fp-lib-table
Remaing KLC-errors: roundrect-pads (will be available in v5) not allow: will be fixed by this PR for the scripts: KiCad/kicad-library-utils#192 Everything else OK like that? |
PS: I renamed the BNC to |
Jan I think that |
Yes, but wouldn't one expect with Should I rename? |
I think the name PanelMountable is ok. I can't think of a better way to communicate what this footprint is meant to represent. An idea would be to add a hexagon on b.fab to signify the nut? This should at least notify users who already selected the footprint once they have it on the board. (or with the new component chooser/footprint browser it is already possible to see this in the preview.) I think this can be merged as is. (@jkriege2 do you want to further play with this footprint or is it ok to merge now?) |
Fine with me ... if I should add the nut, wait until tomorrow with merging, otherwise just merge an add an issue (I could then also add footprints like this for SMA, SMB, ...) ... i.e. up to you! JAN |
I will merge it for now and make an issue. Thanks for the time you put into this already. |
Thanks for review and merging ;-) |