Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix Cherry and Matias keyswitch Fab line thickness #1376

Merged
merged 1 commit into from Feb 5, 2019
Merged

Fix Cherry and Matias keyswitch Fab line thickness #1376

merged 1 commit into from Feb 5, 2019

Conversation

fauxpark
Copy link
Contributor

@fauxpark fauxpark commented Feb 4, 2019

check_kicad_mod.py was complaining about these. Per F5.2.1.a, the recommended Fab line thickness is 0.1mm, though it is allowable up to 0.15mm.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@DanSGiesbrecht DanSGiesbrecht added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Feb 5, 2019
@DanSGiesbrecht DanSGiesbrecht self-assigned this Feb 5, 2019
@DanSGiesbrecht DanSGiesbrecht removed the Pending reviewer A pull request waiting for a reviewer label Feb 5, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Feb 5, 2019

We specifically allowed up to 0.15 to make sure all our old footprints still fulfill the KLC at least in spirit. This is such that users know what to expect.

The testscripts are a bit more strict and try to get everything to the value that we hope to end up with after some amount of time.

@evanshultz
Copy link
Collaborator

@DanSGiesbrecht
I'm going to go ahead and merge this to get it done with 5.1 approaching. It's simple enough and does just what it says on the tin.

@evanshultz evanshultz merged commit b4ad46a into KiCad:master Feb 5, 2019
@evanshultz
Copy link
Collaborator

@fauxpark
Thanks once again!

@fauxpark fauxpark deleted the keyswitch-fab-thickness branch February 5, 2019 21:47
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints: (38 commits)
  Reexport texas qfn footpritns with updated scripts (KiCad#1358)
  Scripted pwqfn-n24 for BQ25601 (KiCad#1402)
  Scripted TI S-PWQFN-N16 EP2.1 for motor drivers (KiCad#1401)
  New scripted version of TI footprints (KiCad#1360)
  Add QFN-64-1EP_8x8mm_P0.4mm_EP6.5x6.5mm (KiCad#1405)
  Added footprint for RECOM RPM-series of DC/DC converters (1A, 2A, 3A and 6A). (KiCad#1382)
  add new vertical fuseholders (KiCad#1326)
  Add Molex 200528 series (scripted via kicad-footprint-generator) (KiCad#1383)
  Button_Switch_THT: Add CK OS102011MS2QN1 footprint (KiCad#761)
  Add SPST relay TE PCN-1xxD3MHZ (KiCad#1357)
  Added battery holder BatteryHolder_TruPower_BH-331P_3xAA (KiCad#1359)
  Added SIM28ML footprint (KiCad#1355)
  add Fischer FK244_13_D2_PAK SMD heatsink (KiCad#1217)
  Connector: Add B6A-PCB-45 from IHI connectors (KiCad#1085)
  Correct JST MPNs (KiCad#1238)
  Rename SIP-3 Packages in Sensor_Current (KiCad#1072)
  Add D52M (KiCad#1117)
  Fixed nonsenses in the 7seg footprint
  Fix Cherry and Matias keyswitch Fab line thickness (KiCad#1376)
  Add Coilcraft LPS5030 (plus freecad source) (KiCad#1340)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants