-
Notifications
You must be signed in to change notification settings - Fork 714
Conversation
Travis fails since the new library does not exist in fp-lib-table. |
@cp-aquila said:
Add the lib to the lib table then ;) Edit: Or add this to the OptoDevice library (Might be the better opition as i doubt that we will ever have a high number of such devices.) |
Sorry for the delay.
Also i just checked out the dimensions of your part and you do seem to have used imperial instead of metric like is both suggested by the datasheet and by kicad in general. |
Hi, Thanks for the review. |
If a datasheet contains both metric and imperial we will use the metric dimensions to check your part. I did that and it failed every measurement. So instead of making a drawing of only red dimensions i simply told you to use the metric dimensions. Edit: In this case i do not even need to point to kicads rules. Metric is the main dimension used in the datasheet and imperial is only added as a legacy reference. |
Nevermind, I was pretty slow in the beginning myself. |
Add LPF-C012303S Lightpipe
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: