Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add LPF-C012303S Lightpipe #1394

Merged
merged 7 commits into from Sep 22, 2019
Merged

Add LPF-C012303S Lightpipe #1394

merged 7 commits into from Sep 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2019

Add LPF-C012303S Lightpipe


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

grafik

  • Datasheet: https://www.lumex.com/spec/LPF-C012303S.pdf
  • I was not sure in which library I should put this; none seemed to fit, so I created a new one. I am open for suggestions and happy to move it to another lib.
  • The additional circles on the F.Fab layer indicate the optimal LED-position
  • Some of the coordinates of the lines are ugly; I drew this mixed imperial/metric. It this is an issue, I can rework it.

@ghost
Copy link
Author

ghost commented Feb 7, 2019

Travis fails since the new library does not exist in fp-lib-table.
I ran the python check lib scripts locally, no error was reported.

@DanSGiesbrecht DanSGiesbrecht added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Feb 7, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Feb 10, 2019

@cp-aquila said:

Travis fails since the new library does not exist in fp-lib-table.

Add the lib to the lib table then ;)


Edit: Or add this to the OptoDevice library (Might be the better opition as i doubt that we will ever have a high number of such devices.)

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 1, 2019

Sorry for the delay.

Is it possible that the datasheet suggests either four rectangular cutouts or for SMD pads. Ok i get it now. These are the suggested pads for the LEDs and are represented by your small crosses on the fab laye


Also i just checked out the dimensions of your part and you do seem to have used imperial instead of metric like is both suggested by the datasheet and by kicad in general.

@poeschlr poeschlr self-assigned this Jun 1, 2019
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Jun 1, 2019
@ghost
Copy link
Author

ghost commented Jun 3, 2019

Hi,

Thanks for the review.
But I fail to understand what the suggested changes are (Pending changes label). Its not clear to me from the last comments.

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 3, 2019

If a datasheet contains both metric and imperial we will use the metric dimensions to check your part. I did that and it failed every measurement. So instead of making a drawing of only red dimensions i simply told you to use the metric dimensions.

Edit: In this case i do not even need to point to kicads rules. Metric is the main dimension used in the datasheet and imperial is only added as a legacy reference.

@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Sep 21, 2019
@poeschlr
Copy link
Collaborator

Sorry it took so long, I kind of missed that this got updated.
Screenshot from 2019-09-22 16-54-59

@poeschlr poeschlr merged commit d340b05 into KiCad:master Sep 22, 2019
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Sep 22, 2019
@ghost
Copy link
Author

ghost commented Sep 23, 2019

Sorry it took so long, I kind of missed that this got updated.

Nevermind, I was pretty slow in the beginning myself.
Thanks for the patience and review!

@ghost ghost deleted the LPF-C012303S branch September 23, 2019 10:46
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Sep 24, 2019
pull bot pushed a commit to maximeborges/kicad-footprints that referenced this pull request Oct 5, 2019
@ghost ghost mentioned this pull request Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants