Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

added Texas_S-PVQFN-N16_EP2.1x2.1mm footprint #1641

Merged
merged 8 commits into from Jun 21, 2019
Merged

added Texas_S-PVQFN-N16_EP2.1x2.1mm footprint #1641

merged 8 commits into from Jun 21, 2019

Conversation

nivekg
Copy link
Contributor

@nivekg nivekg commented Jun 12, 2019

Hey Guys,

I finally created the Texas_S-PVQFN-N16_EP2.1x2.1mm and Texas_S-PVQFN-N16_EP2.1x2.1mm_ThermalVias footprints for the INA3221 symbol (KiCad/kicad-symbols#1343). Not sure if it conforms to the rules, I kept getting python errors when running check_kicad_mod.py

Datasheet: http://www.ti.com/lit/ds/symlink/ina3221.pdf#page=44
Screenshots:
Screenshot from 2019-06-12 11-28-07
Screenshot from 2019-06-12 11-28-35


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2019

CLA assistant check
All committers have signed the CLA.

@antoniovazquezblanco
Copy link
Collaborator

We have recently discovered that the most unique identifier of the footprint is the trhee letter code. The footprint should be named Texas_RGV.

Thanks

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jun 12, 2019
@nivekg
Copy link
Contributor Author

nivekg commented Jun 12, 2019

Cool, will do. Just to understand this, the files should be renamed to Texas_RGV.kicad_mod and Texas_RGV_ThermalVias.kicad_mod

@antoniovazquezblanco
Copy link
Collaborator

Exctly! Thanks!

@nivekg
Copy link
Contributor Author

nivekg commented Jun 12, 2019

Done : )

@poeschlr
Copy link
Collaborator

poeschlr commented Jun 12, 2019

footprints for standardized packages like these really should be generated via the script found here: https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON

Edit: oh and the footprint name must still contain the pin count. So i suggest to include the full name given to it by TI not just the 3 letters.

@poeschlr poeschlr added the Scripting required A scripted version of this contribution is required label Jun 12, 2019
@nivekg
Copy link
Contributor Author

nivekg commented Jun 12, 2019

Oops, I forgot to say the footprint was generated with that script. I'll change the name back.

@evanshultz
Copy link
Collaborator

The footprint does need the three-letter (or sometimes less) designation in it. So Texas_RGV_S-PVQFN-N16_EP2.1x2.1mm may be best. I believe that's what we settled on for other footprints.

@evanshultz
Copy link
Collaborator

And the Python errors are sadly normal. The footprint is built well but the check script isn't smart enough for the way the footprints are built by the script.

@poeschlr
Copy link
Collaborator

please link to the script pull request as the review will happen on it.

…Texas_RGV_S-PVQFN-N16_EP2.1x2.1mm_ThermalVias.kicad_mod
@nivekg
Copy link
Contributor Author

nivekg commented Jun 16, 2019

Hey Guys,

I renamed the footprint to Texas_RGV_S-PVQFN-N16_EP2.1x2.1mm footprint and made a PR for the footprint generator which is pointhi/kicad-footprint-generator#382

@evanshultz evanshultz self-assigned this Jun 20, 2019
@evanshultz
Copy link
Collaborator

Comments left in script PR.

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jun 21, 2019
@evanshultz
Copy link
Collaborator

Please generate a new footprint to take into account the script changes. Thank you.

@nivekg
Copy link
Contributor Author

nivekg commented Jun 21, 2019

added the updated footprint

@evanshultz
Copy link
Collaborator

Great. Thank you!

@evanshultz evanshultz merged commit eb9f7cf into KiCad:master Jun 21, 2019
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
* 'master' of github.com:KiCad/kicad-footprints:
  Increase hole size to 1.3mm (KiCad#1667)
  update Hirose DF63 connector series (KiCad#1649)
  added Texas_S-PVQFN-N16_EP2.1x2.1mm footprint (KiCad#1641)
  added FFC molex series 502231 (KiCad#1636)
  Add SOP-24_7.5x15.4mm_P1.27mm (KiCad#1640)
  add LFCSP-20-1EP_4x4mm_P0.5mm_EP2.6x2.6mm (KiCad#1653)
  Package_DFN_QFN: Add Texas R-PVQFN-N24 (KiCad#1460)
@nivekg nivekg deleted the ina3221_footprint branch June 9, 2020 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Scripting required A scripted version of this contribution is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants