Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Addition of Texas Instruments DC-DC Converter Modules PTN78000 (1.5A)… #2083

Merged
merged 4 commits into from
Feb 15, 2020

Conversation

jamesrlucas
Copy link
Contributor

@jamesrlucas jamesrlucas commented Feb 9, 2020

Addition of a few DC-DC modules from Texas Instruments

I've only done the Through-hole packages for now.

Datasheets PTN78000 PTN78020 and PTN78060

I have not yet created the Symbols, I'll link the PR once complete.

image

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Feb 9, 2020
@jamesrlucas
Copy link
Contributor Author

I've done drawings for the footprints as well. Some of the dimensions are out by 0.01mm - due to rounding of some of the dimensions to establish a centre line (otherwise I'd be working on a 0.005mm grid
PTN78000_Drawing.pdf
PTN78020_Drawing.pdf
PTN78060_Drawing.pdf

@chschlue chschlue self-assigned this Feb 10, 2020
@chschlue chschlue removed the Pending reviewer A pull request waiting for a reviewer label Feb 10, 2020
Copy link
Contributor

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Contributor

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move comp name down.

@jamesrlucas
Copy link
Contributor Author

Done! :)

@chschlue
Copy link
Contributor

Thanks.

@chschlue chschlue merged commit c36da31 into KiCad:master Feb 15, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Feb 17, 2020
@evanshultz
Copy link
Collaborator

I'm not quite sure I agree with these names. They are named by the product, which isn't the package name. The package name could be used for many products.

Take https://www.ti.com/lit/ds/symlink/ptn78000w.pdf for example; you can see in the footprint drawing the package name is EUT and R-PDSS-T5 (for THT version).

I would then name them /Converter_DCDC_Texas_EUT_R-PDSS-T5.kicad_mod. Adding a _THT suffix wouldn't hurt for clarity. And just using EUT should suffice, but it probably doesn't hurt to be a bit more verbose so the footprint is easier to find.

@chschlue
What do you think?

@chschlue
Copy link
Contributor

You certainly have a point there, but I don't think it's quite so easy.

I went with this because it's the usual way of naming footprints in Converter_DCDC (granted, that's mainly because most manufacturers don't have special names for their DC-DC converter packages.)

There are a couple other converters using the same module (according to TI's package search) but that it's currently only used for DC-DC converters is more or less coincidence.

Long story short: I'm not sure artificially restricting this FP to Converter_DCDC is the silver bullet here either as it is basically "vendor-generic".
How about Module/Texas_EUT_R-PDSS-T5.kicad_mod and so on?
(EUT would not suffice BTW as there also is a 6 pin EUT)

@evanshultz
Copy link
Collaborator

Yeah, a lot of the DC-DC stuff we have are modules inside a plastic box whereas these are bare PCBAs.

Your proposal sounds great to me.

@chschlue
Copy link
Contributor

@jamesrlucas Do you have anything to add to this discussion?

@jamesrlucas
Copy link
Contributor Author

I didn't even think about this - I'm more than happy to change these to a more generic footprint name to cover other parts using the same footprints. And I'd agree with keeping it as generic as possible - while all products using that footprint currently are DC-DC converters, that's not to say that will always be the case.

I'll make the changes and submit a new PR over the next few days - and I'll update the symbols I've submitted to refer to the new footprints as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants