Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Update CMakeLists.txt to install only .pretty #291

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

jsreynaud
Copy link
Contributor

@jsreynaud jsreynaud commented Jan 22, 2018

Modify installation to install only *.pretty directories.
All other directories (for example CMakeModules) should not be installed.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

Modify installation to install only *.pretty directories.
All other directories (for example CMakeModules) should not be installed.
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2018

CLA assistant check
All committers have signed the CLA.

@poeschlr
Copy link
Collaborator

I assume you tested this?
@tijuca you seem to know something about make files, is this ok?

@jsreynaud
Copy link
Contributor Author

I had tested it under Linux. Not yet under Windows/Macosx

@tijuca
Copy link

tijuca commented Jan 24, 2018

This is probably the better and correct approach as this installs only the specific folders. Currently I can't test this but I guess Jean-Samuel has done this. I can test this later once I'm home again.

My bad I haven't seen this issue from Jean-Samuel.

@poeschlr
Copy link
Collaborator

Thanks for looking into this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants