Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add C&K PVA1 #373

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add C&K PVA1 #373

wants to merge 5 commits into from

Conversation

strombom
Copy link
Contributor

@strombom strombom commented Feb 15, 2018

C&K PVA1
https://www.ckswitches.com/media/1343/pva.pdf

image

image

image


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@strombom
Copy link
Contributor Author

Does this part have to have origo at pin 1 as the travis script wants?

A mechanical designer will probably specify the center position of the physical button.

Set pin 1 rectangular shape since the button isn't mechanically symmetric.

image

@poeschlr
Copy link
Collaborator

How are other buttons handled?

@strombom
Copy link
Contributor Author

They seem to have a square pin as well as a silkscreen marker:

image

image

image

image

@poeschlr
Copy link
Collaborator

You have the dimensions on the fab layer exchanged. (The 9.8 should be in the same direction as the pin spacing 6 not where the pin spacing is 5)
screenshot from 2018-08-15 18-38-50

@poeschlr poeschlr self-assigned this Dec 31, 2018
@poeschlr poeschlr added Pending changes Addition Adds new footprint to library labels Dec 31, 2018
@poeschlr poeschlr closed this Dec 31, 2018
@poeschlr poeschlr reopened this Dec 31, 2018
@poeschlr
Copy link
Collaborator

poeschlr commented Dec 31, 2018

We have finalized a better naming convention to be used for new contributions. KiCad/kicad-symbols#580

SW_[type]_[poles]P[throws]Tx[quantity]_[NO/NC]_[Latching/Toggle]_[control]_[light]_[options]

SW_Push_2P1T_NO_Toggle_CK_PVA1

@poeschlr
Copy link
Collaborator

poeschlr commented Jan 9, 2019

I took another look at this.

There is a toggle version and a Momentary version of this switch available. As these need different symbols we should use two footprints here.
One is named SW_Push_2P1T_Toggle_CK_PVA1EE, the other SW_Push_2P1T_NO_CK_PVA1OE.
We might also prepare this for including different 3d models depending on button height. (means in the end one footprint per height) meaning add the height code to the name as well. So it would then be for example SW_Push_2P1T_Toggle_CK_PVA1EEH1

@antoniovazquezblanco
Copy link
Collaborator

Ping @strombom

Could you please make the changes requested? Thanks!

@poeschlr poeschlr added the Abandoned Original author has stopped working on the PR label Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants