Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 3.81mm tht diode footprints #766

Merged
merged 4 commits into from Jul 23, 2018
Merged

Conversation

evanshultz
Copy link
Collaborator

2.54mm is too small to run a trace between the pads, and 5.08 is excessively wide if only a thin trace (0.25mm, 0.5mm, etc.) is desirable to run between the pads.

Images:
image

Script update at pointhi/kicad-footprint-generator#153.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@poeschlr
Copy link
Collaborator

I looked at the changes of the script. Looks good to me.

You also changed a datasheet link. This change however is not included here. Could you add a separate PR that updates this in the affected footprints?

@poeschlr poeschlr merged commit bf75cd1 into KiCad:master Jul 23, 2018
@evanshultz evanshultz deleted the 3.81mm-tht-diodes branch July 23, 2018 14:43
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants