Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

INA138/INA168 Schematic symbol has incorrect pinout (again) #1864

Closed
danwood76 opened this issue Dec 1, 2017 · 2 comments
Closed

INA138/INA168 Schematic symbol has incorrect pinout (again) #1864

danwood76 opened this issue Dec 1, 2017 · 2 comments

Comments

@danwood76
Copy link
Contributor

Hi,

This is a repeat of the previous issue I raised with the INA138/INA168 pinout (Issue: #1631). I recently re-opened the project that I used the INA138 in to find it wanted to change the pin out back to the original broken version.

I double checked and the fix that I proposed (and that was accepted) appears to have been reverted by commit c64c1d6.

The pinout of the device is clearly documented and hasn't changed, why was my change reverted?

Regards,
Danny

@bobc
Copy link
Contributor

bobc commented Dec 2, 2017

I think that was just a screw up with someone's branch. Sometimes the history gets confused, and an accidental change gets confused with a good commit. People then incorrectly revert the good commit...

I guess the thing to is to recreate a pull request.

@poeschlr
Copy link
Collaborator

@Danger89 a better option than opening an issue is to fix it and open a pull request.

As we already transitioned over to the new repo i will close this here. I opened a new issue over at the new repo: KiCad/kicad-symbols#181

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants