Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Bump ngspice to ngspice-30-2 #256

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Bump ngspice to ngspice-30-2 #256

merged 1 commit into from
Jan 3, 2019

Conversation

nickoe
Copy link
Contributor

@nickoe nickoe commented Jan 2, 2019

I am not sure where there is a ngspice-30 and ngspice-30-2 tag upstream,
but I guess we should choose the dash two version.

I am not sure where there is a ngspice-30 and ngspice-30-2 tag upstream,
but I guess we should choose the dash two version.
@nickoe
Copy link
Contributor Author

nickoe commented Jan 3, 2019

@adamwolf Any concerns or should I merge it and we will see if it works on the nightlies?

@adamwolf
Copy link
Contributor

adamwolf commented Jan 3, 2019 via email

@adamwolf
Copy link
Contributor

adamwolf commented Jan 3, 2019 via email

@nickoe nickoe merged commit 9a653c6 into KiCad:master Jan 3, 2019
@adamwolf
Copy link
Contributor

adamwolf commented Jan 5, 2019

Gotta reject it, unfortunately.

03:08:47 default: [ 57%] Building CXX object eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o
03:08:48 default: In file included from /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.cpp:28:
03:08:48 default: /vagrant/build/kicad/src/kicad/eeschema/sim/ngspice.h:31:10: fatal error: 'ngspice/sharedspice.h' file not found
03:08:48 default: #include <ngspice/sharedspice.h>
03:08:48 default: ^
03:08:49 default: 1 error generated.
03:08:49 default: make[6]: *** [eeschema/CMakeFiles/eeschema_kiface.dir/sim/ngspice.cpp.o] Error 1

@adamwolf adamwolf mentioned this pull request Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants