Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

IRM-03-xx_THT model rotated 90 degrees from footprint #600

Open
LambertusIJsselstein opened this issue Jul 30, 2019 · 11 comments
Open

IRM-03-xx_THT model rotated 90 degrees from footprint #600

LambertusIJsselstein opened this issue Jul 30, 2019 · 11 comments
Labels
Bug Fix package 3D existing in the library Help wanted

Comments

@LambertusIJsselstein
Copy link

The 3D model for the IRM-03-xx-THT part in package Converter_ACDC is rotated 90 degrees from the footprint:
IRM-05-xx-THT_rotation

@poeschlr poeschlr added Bug Fix package 3D existing in the library Help wanted labels Jul 30, 2019
@EeliK
Copy link

EeliK commented Aug 28, 2019

The whole model is wrong, it's mirrored. See https://www.tme.eu/Document/4ddeead22020b5eb532ee6fb8f44e788/IRM-03-spec.pdf

Franck78 added a commit to Franck78/kicad-footprints that referenced this issue Sep 3, 2020
@Franck78
Copy link

Franck78 commented Sep 3, 2020

corrected footprint submitted here:

KiCad/kicad-footprints@4a7a688

Sorry for the the mess but this whole github + git is pile a crap. I wanted 'one or two patches' per branches one branch one PR.

@evanshultz
Copy link
Collaborator

@Franck78
It looks like the footprint is fine to me. The origin and rotation are correct for a THT footprint. It's the 3D model that needs to be fixed.

@Franck78
Copy link

Franck78 commented Sep 3, 2020

euh no ! You have the pdf. for comparison.

@Franck78
Copy link

Franck78 commented Sep 3, 2020

eu yes ! bottom view says the datasheet.
So just make the orientation same as other IRM THT is ok.

And redraw the the 3d

1 similar comment
@Franck78
Copy link

Franck78 commented Sep 3, 2020

eu yes ! bottom view says the datasheet.
So just make the orientation same as other IRM THT is ok.

And redraw the the 3d

Franck78 added a commit to Franck78/kicad-packages3D that referenced this issue Sep 4, 2020
For some reason the previous one was bad.
Rerun the script for FreeCad and now it"s ok
The .step was good.

Fixes: KiCad#600
@Franck78
Copy link

Franck78 commented Sep 4, 2020

@evanshultz ,
regenerated wrl for this thing is here:
Just from the script

https://github.com/KiCad/kicad-packages3D/compare/master...Franck78:pwled?expand=1

@evanshultz
Copy link
Collaborator

@Franck78
Thanks for looking at this. If you've fixed it, please submit the STEP and WRL files as a PR to the repo so it can be reviewed and merged. And if you corrected a script, please submit a PR for that as well. Again, I'm not too familiar with the 3D model part of the library.

@Franck78
Copy link

Franck78 commented Sep 4, 2020

  • the existing .step is OK. No need to change
  • the script is not modified
  • the PR done 'pwled', updated with photos

acdc-back

@Franck78
Copy link

Franck78 commented Sep 5, 2020

while working with the sourcefiles for building this image, I also noticed missing or wrong 3dmodels for

  • hilink_hlk
  • IRM-05
  • IRM-10
  • IRM-60
  • RAC-05
  • TMG-15
  • Syntec
  • CRE1
  • MGJ2D
  • MGJ3
  • NCS1S
  • TDN-05
  • THD-15
  • TMR 1SM
  • TMR-2
  • XPPOWER

Probably a lot of them doable with the script, meaning doing the job of updating the 3drepo only 'once'.

Don't merge to soon, but not in ten years ;)

@Franck78
Copy link

Franck78 commented Sep 8, 2020

~140 3dmodels ready (scripted).

what next Librarians ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix package 3D existing in the library Help wanted
Projects
None yet
Development

No branches or pull requests

5 participants