Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added 3D models of audiojacks #495

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Misca1234
Copy link
Collaborator

@Misca1234 Misca1234 commented Dec 31, 2018

Added a number of 3D models fo the audio jacks

3D model push
#495

3D model script push
easyw/kicad-3d-models-in-freecad#254

bild

bild

bild

bild

bild


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@myfreescalewebpage myfreescalewebpage added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Jan 7, 2019
@diegoherranz
Copy link
Collaborator

Thanks for sending these.

The NMJ6HCD2 is a 6.35mm jack and not 3.5mm. It is wrong in the footprints library currently. See KiCad/kicad-footprints#1145 which tries to submit many Neutrik connectors.
We need to make sure that the 3D models match the name of the footprints on that PR which will eventually make it into the repo.

The aperture for the plug looks a bit too small in your NMJ6HCD2 model?

Thanks again!

@Misca1234
Copy link
Collaborator Author

Neautrik changed to 6.35 hole, including the filename

bild

@Shackmeister Shackmeister added the Pending footprint Pending footprint acceptance before merging label Feb 3, 2019
@chmorgan chmorgan self-requested a review March 16, 2020 00:17
@chmorgan chmorgan self-assigned this Mar 16, 2020
@chmorgan
Copy link
Collaborator

Hi @Misca1234 I see the rename of the Jack_3.5mm_Neutrik_NMJ6HCD2_Horizontal to 6.35mm but there isn't a footprint for 6.35mm in the footprint library.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connector_Audio.3dshapes/Jack_3.5mm_CUI_SJ1-3533NG_Horizontal.step | Bin 0 -> 71185 bytes
Connector_Audio.3dshapes/Jack_3.5mm_CUI_SJ1-3533NG_Horizontal.wrl | Bin 0 -> 42552 bytes
Looks good

Connector_Audio.3dshapes/Jack_3.5mm_Ledino_KB3SPRS_Horizontal.step | Bin 0 -> 92722 bytes
Connector_Audio.3dshapes/Jack_3.5mm_Ledino_KB3SPRS_Horizontal.wrl | Bin 0 -> 71264 bytes
Looks good

Connector_Audio.3dshapes/Jack_3.5mm_Neutrik_NMJ6HCD2_Horizontal.step | Bin 0 -> 394354 bytes
Connector_Audio.3dshapes/Jack_3.5mm_Neutrik_NMJ6HCD2_Horizontal.wrl | Bin 0 -> 170099 bytes
Deleted when converted to 6.35mm but there doesn't appear to be a 6.35mm footprint.

Connector_Audio.3dshapes/Jack_3.5mm_PJ31060-I_Horizontal.step | Bin 0 -> 174804 bytes
Connector_Audio.3dshapes/Jack_3.5mm_PJ31060-I_Horizontal.wrl | Bin 0 -> 97400 bytes
Looks good

Connector_Audio.3dshapes/Jack_3.5mm_PJ320D_Horizontal.step | Bin 0 -> 100081 bytes
Connector_Audio.3dshapes/Jack_3.5mm_PJ320D_Horizontal.wrl | Bin 0 -> 74816 bytes
The pads here don’t align with the footprint.

Connector_Audio.3dshapes/Jack_3.5mm_PJ320E_Horizontal.step | Bin 0 -> 92752 bytes
Connector_Audio.3dshapes/Jack_3.5mm_PJ320E_Horizontal.wrl | Bin 0 -> 64933 bytes
Looks good.

Connector_Audio.3dshapes/Jack_3.5mm_QingPu_WQP-PJ398SM_Vertical.step | Bin 0 -> 250661 bytes
Connector_Audio.3dshapes/Jack_3.5mm_QingPu_WQP-PJ398SM_Vertical.wrl | Bin 0 -> 281091 bytes
Looks good.

@evanshultz
Copy link
Collaborator

There was an issue with that Neutrik jack's description and maybe name. I can't quite recall. But it will be fixed once KiCad/kicad-footprints#1145 is merged. So you could optionally align any naming with that PR now since the existing footprint has known issues.

@Franck78
Copy link

It is merged.
KiCad/kicad-footprints#1145

This PR can evolve no ?

@Franck78
Copy link

Sent fix for the script generating the bad 320D jack

The obvious error easily fixed
pj320-inv
pj320-good

6.5mm_Neutrik_NMJ6HCD2 do have a foot print available
nmj6

Here are the WRML&STEP from the script
Jack_3.5mm_PJ320D_Horizontal.zip

Total 7 3dmodels ready to go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants