Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added 3D for ProAnt PRO-OB-440 antenna. #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cnieves1
Copy link
Contributor

Footprint depends on: KiCad/kicad-footprints#2002
Datasheet: http://www.proant.se/files/user/Documents/Datasheets%20and%20appnotes/OnBoard%20SMD/Application%20Notes/2019-09-25/OnBoard%20SMD%202400%20rev4.3.pdf

imagen

imagen

imagen

Replace this line with your commit message! Please provide a description of your pull request


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@claassistantio
Copy link

claassistantio commented Dec 13, 2019

CLA assistant check
All committers have signed the CLA.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new package 3D to library Missing source Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Jan 2, 2020
@antoniovazquezblanco
Copy link
Collaborator

Could you please link the source of your model?

Thanks!

@cnieves1
Copy link
Contributor Author

cnieves1 commented Jan 2, 2020

Done: KiCad/kicad-packages3D-source#250

@Misca1234 Misca1234 added Pending changes User is expected to perform fixes before merging and removed Pending reviewer A pull request waiting for a reviewer labels Jan 19, 2020
@Misca1234 Misca1234 self-requested a review January 19, 2020 09:23
@Misca1234
Copy link
Collaborator

Hi

Thanks for the contribution

Very nice model, but the .Fcstd file should not be part of the push, the .fcstd file should be seperatly pushed to https://github.com/KiCad/kicad-packages3D-source

All measurements look ok, it can be merged when foot print is accepted (but not before the .fcstd file is removed from the push)

@cnieves1
Copy link
Contributor Author

Removed Fcstd file from commit...

@Misca1234 Misca1234 removed the Pending changes User is expected to perform fixes before merging label Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library Pending footprint Pending footprint acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants