Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added DFN-8-1EP_2x2mm_P0.5mm_EP0.7x1.3mm. #625

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

cnieves1
Copy link
Contributor

Generated using script, PR at: easyw/kicad-3d-models-in-freecad#325

imagen
imagen
imagen


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items as you complete them:

  • A screenshot of the model(s) aligned with KiCad footprints is very useful
  • Was the 3D model(s) created in a mechanical modelling program?
  • Source files (or scripts) have been contributed
  • Step model submitted in 1:1 scale
  • WRL model submitted in 1:2.54 scale
  • 3D model alignment checked against KiCad footprint
  • WRL model uses correct material properties
  • Geometry check performed against mechanical models

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new package 3D to library Pending reviewer A pull request waiting for a reviewer labels Jan 2, 2020
@Misca1234
Copy link
Collaborator

Hi

Thanks for you contribution

Why have you named the 3D model to DFN-8-1EP_2x2mm_P0.5mm_EP0.7x1.3mm
when, according to data sheet https://www.onsemi.com/pub/Collateral/NUF4401MN-D.PDF
the EP is 1.4x0.75 mm ?
and in the paramterfile you have set
epad = (1.2,0.6), # e Pad #epad = None, # e Pad

You have also set
ps = 'rounded', # rounded pads
when they should be rectangle

The datasheet link should be changed from
'': Params( # from https://www.onsemi.com/pub/Collateral/506AQ.PDF

' Params( # from https://www.onsemi.com/pub/Collateral/NUF4401MN-D.PDF

@cnieves1
Copy link
Contributor Author

Sorry, I'm afraid I need further clarification....

I don't understand why you are saying the EP is 0.75x1.4mm.
The EP is D2*E2 = 0.5:0.7-1.1:1.3mm, where nominal size is 0.6x1.2mm. See below:

imagen

If I get these values into:
pointhi/kicad-footprint-generator#452
Then the EP in the footprint I get is 0.7x1.3mm, and the 3D model should be named like that.

So, regarding naming:

  • Real package EP nominal size is 0.6x1.2mm
  • Footprint EP size is 0.7x1.3mm. Footprint name matches the footprint's EP size.
  • 3D package size: physical EP is again 0.6x1.2mm. Should 3D name match the footprint name or the real package EP size?

It the name is DFN-8-1EP_2x2mm_P0.5mm_EP0.6x1.2mm, then it would match the phyisical EP size, but it wouldn't match the footprint name.

The script https://github.com/easyw/cadquery/FCAD_script_generator/QFN_packages/cq_parameters.py has the option modelName, so in theory, we could have a DFN-8-1EP_2x2mm_P0.5mm_EP0.7x1.3mm footprint pointing to a DFN-8-1EP_2x2mm_P0.5mm_EP0.6x1.2mm 3D model file.
However, I can't found any match like this in that file.
So, what is the policy here?

Regarding datasheet link: again there is a mixed world in the script. Some links to a specific part name with a specific function while others link to a generic package drawing link.
As the package drawing, generally speaking, has nothing to do with its function or a specific part number, I understood the generic policy was link to a package drawing unless there is none available. Again, could you clarify the policy?

I agree on setting ps='rectangle' instead of ps='round'.

Thanks,

@cnieves1
Copy link
Contributor Author

When posting, I have just saw why you were talking about EP size 0.75x1.4mm...

It is the landpattern recommended EP size given by the manufacturer. However, your script at:
https://github.com/easyw/kicad-3d-models-in-freecad/pull/325/files
does not use recommended land pattern, but it calculates its size using minimum and maximum physical EP size.

Therefore, I can not use 0.75x1.4mm EP size.

This PR is about 3D model, which should follow the package dimensions, not the recommended land pattern....
So, please clarify the naming and datasheet link policy as requested by the above comment.

Thanks,

@cnieves1
Copy link
Contributor Author

Again another issue: it seems both rectangle and round terminals are used:
imagen

The 3D generator uses the round terminal model, so ps='round' is correct.

imagen

@chschlue chschlue removed the Pending reviewer A pull request waiting for a reviewer label Aug 6, 2020
@chschlue chschlue self-assigned this Aug 6, 2020
Copy link
Contributor

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chschlue chschlue merged commit a7a1979 into KiCad:master Aug 6, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.7 milestone Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants