Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

MCU #10

Merged
merged 13 commits into from
Dec 5, 2017
Merged

MCU #10

merged 13 commits into from
Dec 5, 2017

Conversation

SchrodingersGat
Copy link
Contributor

This PR adds all the MCU_xx libraries. Incorrect footprint associations have been (somewhat) fixed, as far as can be done automatically.

@evanshultz
Copy link
Collaborator

@SchrodingersGat Can you check the script output?

Many of these have a "/" in the name, since Microchip likes to do that. I also see opening and closing parentheses. All 3 chars are in violations of KLC. Should those be fixed before merging?

@poeschlr
Copy link
Collaborator

From mailing list i gather that "/" is a problem with the new symbol-lib-table. So we should try to avoid this char if at all possible.

@SchrodingersGat
Copy link
Contributor Author

I have fixed the / issues across these libs. I have also changed all instances of (e.g.) PIC16(L)F to simply PIC16F

  • I do not have the time to add aliases for L variant
  • They are all pin compatible anyway

@evanshultz
Copy link
Collaborator

Sounds like you've done all that you want to do right now.

@evanshultz
Copy link
Collaborator

However, there are still some issues that may be serious. Missing FPfilters, incorrect footprint fields, missing DCM entries (at least some of these are because the DCM still has the /), etc. I assume at least some of that should be fixed before merging.

@SchrodingersGat
Copy link
Contributor Author

I had an extra commit sitting on my computer that I had not pushed, fixing those DCM files. Should be ok now (at least for the slashes)

@SchrodingersGat
Copy link
Contributor Author

If there are any issues that are "worse" than current v4 libs please raise them, otherwise merge :)

@SchrodingersGat
Copy link
Contributor Author

@poeschlr I think this is OK to merge. I shall create an ongoing issue for this after merge.

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 5, 2017

Yup looks good as well.

@poeschlr poeschlr merged commit 65da667 into KiCad:master Dec 5, 2017
jkriege2 pushed a commit that referenced this pull request Jun 1, 2018
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 28, 2019
myfreescalewebpage pushed a commit that referenced this pull request Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants