Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fix KLC errors on Memory_RAM:628128 #1441

Merged
merged 9 commits into from
Feb 21, 2019
Merged

Fix KLC errors on Memory_RAM:628128 #1441

merged 9 commits into from
Feb 21, 2019

Conversation

fauxpark
Copy link
Contributor

sym

Datasheet: http://www.futurlec.com/Datasheet/Memory/628128.pdf

No idea if this should have a more specific name, it appears to be a somewhat jellybean part.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Jan 20, 2019
@evanshultz evanshultz self-assigned this Feb 15, 2019
@evanshultz
Copy link
Collaborator

This seems to be an old part that is no longer in production. I don't find a direct manufacturer datasheet so I guess we aren't going to get better than this. It does seem to be a generic name so I'm OK leaving it alone.

You've totally redone this symbol, but it was terrible before. Here it is:
image

Let's hold off until after the final 5.1 library is released to merge this so it will go into v6. But as the original symbol was so bad, and it's very likely to not be used much, the risk of breaking a few schematics is worth this major improvement.

Notes:

  • It looks like there are other access times besides 55ns. Could you add 70ns or remove that from the description?
  • Only the DIP and SOP packages use this pinout. TSOP is different.
  • Can you move the ref des and value down 50mil to be just above the part body?

Thanks as always!

@fauxpark
Copy link
Contributor Author

Added 70ns and moved the refdes/value down. As for the pinouts - I could have sworn they were all the same...

@fauxpark
Copy link
Contributor Author

According to the datasheet there is another TSOP package for this part with a "reversed" pinout - looks like reverse mount judging from the drawing. There's no footprint for it but since as you said this is a pretty old part I don't feel particularly motivated to add it.

@poeschlr
Copy link
Collaborator

We are not obliged to offer symbols (and therefore footprints) for every part. Not even all available alternatives to parts in the lib. The question about the production state of the part does not even come into play here. (But well it makes even less sense to put work into maintaining obsolete or soon to be obsolete partts.)

@evanshultz
Copy link
Collaborator

  • Use underscores to separate the part name from the package where there are multiple vendors with conflicting MPN suffixes for the same part and package combination. See Analog:LF398_DIP8 and Regulator_Linear:LT1175-5_SO8_DIP8 for examples
  • How is one supposed to know the TSOP symbol is for the normal pinout? Maybe add something in the description? Without the reversed symbol also there's no way to tell by the description. I'll merge as is but if you think of something clear you can add it. As the original symbol was only for DIP/SSOP you haven't removed any symbols even if the TSOP isn't present, but since you've already made it I don't at all object to keeping it.

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Feb 19, 2019
@fauxpark
Copy link
Contributor Author

fauxpark commented Feb 19, 2019

I originally thought the reverse TSOP package was meant to be mounted inside the board, but that is actually not the case. According to this question, it allows for placing the part on both sides of the board with "a minimum of wiring congestion". The pinout is exactly the same, but it is mirrored horizontally.

So the footprint is pretty easy to create - it might not be scriptable though.

@evanshultz
Copy link
Collaborator

Great. Is there any reason to make the description more clear that this is normal/non-reverse?

@fauxpark
Copy link
Contributor Author

There is no difference as far as the symbol is concerned, the pinout is the same. I'm submitting a PR now for the reverse mount footprint with the suffix _Reverse, so unless that needs to be changed the current footprint filters should pick it up.

@evanshultz
Copy link
Collaborator

Thanks!

@evanshultz evanshultz merged commit 01bdaa6 into KiCad:master Feb 21, 2019
@fauxpark fauxpark deleted the 628128-klc-fix branch February 21, 2019 23:50
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.0 milestone Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants