Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Replace sensor/Geiger-Muller with sensor/Nuclear-Radiation_Detector #1550

Merged
merged 1 commit into from Feb 22, 2019

Conversation

heitorPB
Copy link
Contributor

fix #1519

Symbol on a 50 mil grid:
nuke

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Feb 19, 2019
@myfreescalewebpage myfreescalewebpage added this to the 5.1.0 milestone Feb 19, 2019
@evanshultz evanshultz self-assigned this Feb 19, 2019
@evanshultz
Copy link
Collaborator

  • The description should not be a copy of the symbol name. Describe that this device does.
  • I'm fine with no datasheet link (just a tilde as was done before).
  • Perhaps "muller" should also be a keyword to help searching without diacritics or for users that aren't familiar with the representations of umlauts?
  • I'm not sure about the pin names. Why C1 and C2? It looks like the tube has an anode and cathode, which for a diode in our library are named A and K.
  • Are there any footprints existing or that you plan to add? Perhaps we can use a footprint filter?

@heitorPB
Copy link
Contributor Author

This is a generic symbol, for multiple radiation detectors. So, no footprint.

About the pin names, I renamed to 1 and 2.

As for the descriptio, Generic radiation detector is enough?

@evanshultz
Copy link
Collaborator

I'd like to get more feedback on pin names. Are 1 and 2 OK, or is A and K better?

I realize this is a generic symbol, but there may be something about the footprint naming that we can key on in the footprint filter. See LED symbol in Device..lib I just don't know what that would be without knowing that footprints might be used. Leaving it blank is OK, too, if that's best.

The description is fine if nobody has other suggestions.

Would you please not force push commits? It's easier to see changes. Thank you. I'll squash merge so the commit history will be clean.

@poeschlr
Copy link
Collaborator

Regarding pin names: How are they called in the datasheets? Do datasheets use numbers? If so use numbers. If not use letters.

I assume that these come only in highly specialized packages. (Unlike for example diodes) This is why i would be ok with letters.

@heitorPB
Copy link
Contributor Author

The datasheets I read about Geiger-Mueller tubes don't say anything about the pin names. Some said ground lead for one of the pins. But if this symbol would be more general than only Geigers, I'd be more confortable with 1 and 2.

They come in very specialized packages and sizes.

@evanshultz
Copy link
Collaborator

I suppose this is OK and no more comments have been added in a couple days. I'll merge this in a few hours if there is no more feedback.

@evanshultz
Copy link
Collaborator

Thank you!

@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Feb 25, 2019
@evanshultz evanshultz mentioned this pull request Mar 19, 2019
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Geiger-Müller symbols
5 participants