Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add/correct FP filters for jumper symbols #1580

Merged
merged 3 commits into from
Feb 28, 2019

Conversation

evanshultz
Copy link
Collaborator

In Jumper.lib some of the symbols didn't have a properly formatted FP filter so they didn't pick up any footprints in CvPcb. And the jumper symbols in Device.lib didn't have any FP filter. So... here is the fix.

I also found one FP filter that was missing the leading "Solder".

Checked in KiCad and jumpers appear in CvPcb now. Yay!


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@evanshultz evanshultz added the Bug Fix symbol existing in the library label Feb 26, 2019
@evanshultz evanshultz added this to the 5.1.0 milestone Feb 26, 2019
@poeschlr
Copy link
Collaborator

thanks.

@poeschlr poeschlr merged commit 1eb50d8 into KiCad:master Feb 28, 2019
@evanshultz evanshultz deleted the jumper-fp-filter-fix branch February 28, 2019 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants