Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding Samtec ASP-134486-01 connector (ASP-134602-01 alias) #1703

Merged
merged 2 commits into from Sep 16, 2020

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Mar 31, 2019

Adding Samtec ASP-134486-01 connector (ASP-134602-01 alias)
Datasheet
Part A (from 10 parts total) screenshot:
ASP_new

Footprint PR


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Apr 1, 2019
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 18, 2019
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 18, 2019
@myfreescalewebpage
Copy link
Collaborator

@ki5libs thanks for this alias.
The review is ok for me but I would like @evanshultz who have a larger experience with connectors to have a look too: it's an alias of an existing connector. The original is THT, the new one is SMD version. I wonder for this kind of very specific part if they should be atomic or not.... ?
Joel

@myfreescalewebpage
Copy link
Collaborator

@evanshultz if you can share your experience here, thanks

@myfreescalewebpage
Copy link
Collaborator

@evanshultz ping! If you can look at my previous comment here please. Thanks Joel

@myfreescalewebpage
Copy link
Collaborator

Back to this PR, for me it's great.
@ki5libs can you solve the branch conflict then I will merge.
Thanks

@ki5libs
Copy link
Contributor Author

ki5libs commented Sep 12, 2020

Hi @myfreescalewebpage

conflict is solved.

@myfreescalewebpage
Copy link
Collaborator

Thanks, merging.

@myfreescalewebpage myfreescalewebpage merged commit f2ea87c into KiCad:master Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants