This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong footprint by default, which sould be Sx39-1x, but ends up being the symbol name.
…int names were not fitting.
Hi @Solartraveler , thanks for contributing, A few comments I have during my review:
Then will do a full review. Cheers, |
myfreescalewebpage
added
the
Pending footprint
Pending footprint acceptance before merging
label
May 31, 2019
Okay, I hope, I have changed everything as requested. But I guess I missed something ;) |
Great job done here ! |
Signed-off-by: Solartraveler <Solartraveler@users.noreply.github.com>
Signed-off-by: Solartraveler <Solartraveler@users.noreply.github.com>
Somehow two lines and SC39-12EWA was lost
Okay, the footprint is now merged with KiCad/kicad-footprints#1866 |
myfreescalewebpage
removed
the
Pending footprint
Pending footprint acceptance before merging
label
Nov 10, 2019
Hi @Solartraveler and sorry for the delay. Seems everything is ok, no more comment to do, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add symbols for SA39-11, SC39-11, SA39-12, SC39-12 10x13mm Kingbright 7 segment LED displays
There are four colours available, with some suffix. I always added the datasheet link to the red ones. I successfully manufactured a PCB with three SC39-11YWA. I added the other variants for sake of completeness. The symbol is actually taken from one of the other 7segment display from the kicad lib - just the pin layout has been adjusted.
The pullrequest for the footprint is: KiCad/kicad-footprints#1618