Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

7 seg symbol #1896

Merged
merged 9 commits into from Nov 10, 2019
Merged

7 seg symbol #1896

merged 9 commits into from Nov 10, 2019

Conversation

Solartraveler
Copy link
Contributor

@Solartraveler Solartraveler commented May 31, 2019

Add symbols for SA39-11, SC39-11, SA39-12, SC39-12 10x13mm Kingbright 7 segment LED displays


There are four colours available, with some suffix. I always added the datasheet link to the red ones. I successfully manufactured a PCB with three SC39-11YWA. I added the other variants for sake of completeness. The symbol is actually taken from one of the other 7segment display from the kicad lib - just the pin layout has been adjusted.

The pullrequest for the footprint is: KiCad/kicad-footprints#1618

7segment-symbol

@CLAassistant
Copy link

CLAassistant commented May 31, 2019

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage self-assigned this May 31, 2019
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 31, 2019
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented May 31, 2019

Hi @Solartraveler , thanks for contributing,

A few comments I have during my review:

  • First of all can you sign the CLA, which is a mandatory condition to accept your contribution ? Thanks.
  • The design should be consistent with other 7 segment display in the library: one alias for each color, footprint name, footprint filter, etc. Look at other device from the same manufacturer in the library, for example SA15-11SRWA

Then will do a full review.

Cheers,
Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label May 31, 2019
@Solartraveler
Copy link
Contributor Author

Okay, I hope, I have changed everything as requested. But I guess I missed something ;)

@myfreescalewebpage
Copy link
Collaborator

Great job done here !
I have just done a full review, no comment to do, perfect job!
Just need to wait the footprint before merging.
Thanks.
Joel

Signed-off-by: Solartraveler <Solartraveler@users.noreply.github.com>
Signed-off-by: Solartraveler <Solartraveler@users.noreply.github.com>
Somehow two lines and SC39-12EWA was lost
@Solartraveler
Copy link
Contributor Author

Solartraveler commented Sep 22, 2019

Okay, the footprint is now merged with KiCad/kicad-footprints#1866
And I have resolved conflicts with the current master branch.
As suggested in KiCad/kicad-footprints#1618 (comment)
I have added the first used Email to my Git account - hope this helps, so I dont need a new pull request here.

@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Nov 10, 2019
@myfreescalewebpage
Copy link
Collaborator

Hi @Solartraveler and sorry for the delay. Seems everything is ok, no more comment to do, merging.

@myfreescalewebpage myfreescalewebpage merged commit 794e0a7 into KiCad:master Nov 10, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants