Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add ICE40HX4K-BG121 alias #1985

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Add ICE40HX4K-BG121 alias #1985

merged 2 commits into from
Sep 10, 2020

Conversation

twam
Copy link
Contributor

@twam twam commented Jul 16, 2019

Only added an alias to existing component.

Although no differences to be expected as this is a pin-compatible 'lower' version of the same device I checked all pins individually.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 16, 2019
@twam
Copy link
Contributor Author

twam commented Aug 9, 2019

Any chance to get this merged?

@cpresser
Copy link
Contributor

Hi,
I did find some pins that are not identical

  • J7
  • H4
  • H5
  • D6

I did this comparison by taking the two .xlsx files, sorting them by the BGA-121 row and putting them next to each other.

@cpresser cpresser self-assigned this Oct 16, 2019
@cpresser cpresser added Pending changes User is expected to perform fixes before merging and removed Pending reviewer A pull request waiting for a reviewer labels Oct 16, 2019
@twam
Copy link
Contributor Author

twam commented Oct 17, 2019

You're right! I only checked that all pins on the lower version equal the higher one, but didn't expect that there are more pins on the higher version.

So this needs an extra component. :(

@cpresser
Copy link
Contributor

you can do this by doing a copy of the existing symbol first.
then change just the pins that differ.
if there are two separate commits for that its easy to review for me.

@twam
Copy link
Contributor Author

twam commented Oct 17, 2019

Something is fishy there. The excel file misses those pins but in the data sheet they have exactly the same number:
Screenshot 2019-10-17 at 16 42 17

@cpresser
Copy link
Contributor

That is indeed weird.
Are there other files you can check? BDSL? Or perhaps from within ICEcube2?

@twam
Copy link
Contributor Author

twam commented Oct 17, 2019

I wrote an eMail to the technical support from Lattice. Let's see if I get an answer.

@twam
Copy link
Contributor Author

twam commented Jan 6, 2020

I wrote an eMail to the technical support from Lattice. Let's see if I get an answer.

Didn't get any reply so far. Back then the Technical Support form didn't work. Tried again to today and was able to file a report. ID is C154546-010620.

@myfreescalewebpage
Copy link
Collaborator

@twam @cpresser what is the status here ?

@twam
Copy link
Contributor Author

twam commented Sep 10, 2020

Still no reply from Lattice.

I'm pretty sure, that this is only an error in the excel file, but cannot guarantee that. If you want absolute certainty I suggest to discard this.

@cpresser
Copy link
Contributor

Unsure. We have conflicting information.

I did some more googling and found this which indicates they are compatible:
https://github.com/YosysHQ/icestorm/pull/132/files

I compared the two arrays 8k-bg121 and 8k-bg121:4k and they are the same.
That is one more data-point to show they are identical.

The pinout .xls files have not been updated since 2017
image

There are OrCad symbols for download, But I don't have the software to open them for inspection.

@cpresser
Copy link
Contributor

The BG121 parts are not in the OrCad file. Yay.
But there is another document called MigrationSheet. There the 4k and 8k are identical.
Also people on IRC confirmed that they have the same die, so why would they be bonded differently.

@cpresser cpresser merged commit 5ed3b35 into KiCad:master Sep 10, 2020
@cpresser cpresser removed the Pending changes User is expected to perform fixes before merging label Sep 10, 2020
@cpresser cpresser added this to the 6.0.0 milestone Sep 10, 2020
@twam twam deleted the ice40 branch September 11, 2020 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants