Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add AD654 #2571

Merged
merged 2 commits into from Apr 1, 2020
Merged

Add AD654 #2571

merged 2 commits into from Apr 1, 2020

Conversation

evanshultz
Copy link
Collaborator

https://www.analog.com/media/en/technical-documentation/data-sheets/AD654.pdf
image
image

This felt like the best library but let me know if we have any V-F converters I didn't find or if there's a better place.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Mar 24, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Mar 27, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Mar 27, 2020
@myfreescalewebpage
Copy link
Collaborator

Hello @evanshultz

I have trouble with the transistor on pins 1/2. Sometimes pin 2 is not Power Input has shown on figure 11 page 9 of the datasheet. Seems the transistor wiring has no specific constraint. I suggest the pins 1 and 2 to be Passive:

Capture

Joel

@evanshultz
Copy link
Collaborator Author

@myfreescalewebpage
Both figures on page 9 show pin 2 going to ground. Can you please check that? Since the pin is named LOGIC COMMON I expect that while it's shown as the output transistor's emitter it's also the ground for all other circuitry and the IC won't work right if it's not grounded. There could be some application where it's not, but I've not seen it and the datasheet doesn't allude to it. Have I overlooked anything?

I don't find anything regarding pin 1's type like I noted above, but it seems Open Collector is valid and isn't likely to result in any ERC or wiring issues. And it probably is truly an open collector pin. Did you find a case where this would cause issues?

@myfreescalewebpage
Copy link
Collaborator

@evanshultz oupsss sorry, have check again you're right, it's connected to ground.

Anyway, I'm not sure it is mandatory to connect it to the ground. First page of the datasheet it is indicated "The Logic Common terminal can be connected to any level between ground (or –VS) and 4 volts below +VS". I think emitter follower configuration is possible.

@evanshultz
Copy link
Collaborator Author

Ah. Thanks for pointing that out. The change you're suggesting seems OK but I'm curious now.

My guess is that emitter follower is not possible as the pin is also the 'bottom' of internal current sources which need 4V+ to operate. I asked ADI for clarification.

@evanshultz
Copy link
Collaborator Author

evanshultz commented Apr 1, 2020

@myfreescalewebpage
Response from ADI:

The FOUT signal is referenced to LOGIC COMMON. In the datasheet diagrams, the pin is connected to GND (0V) externally. The NPN emitter is connected to the same potential. 
The LOGIC COMMON can be connected to a DC voltage from –VS to (+VS – 4V). The reference voltage for FOUT changes accordingly.
The LOGIC COMMON is not connected to other circuitry internally.

So my guess was wrong. Since pin 2 needs to be connected to a DC voltage I'm still in favor of keeping Power Input type. And would Open Collector still be fine for pin 1?

Edit: I just checked again and that is the current state of the commit. So are there any changes needed?

@myfreescalewebpage
Copy link
Collaborator

Ok with the current status, you can post a fix later if you have ERC issues for example.

@myfreescalewebpage myfreescalewebpage merged commit c2e51e5 into KiCad:master Apr 1, 2020
@evanshultz evanshultz deleted the ad654 branch April 1, 2020 21:42
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Apr 2, 2020
jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
* Add AD654

* Fix +VS pin number to 8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants