This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Fixed broken install prefix setting #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work for macOS users. It will try to install to /usr/local/share/kicad (which does not exist) and fails without installing anything. This is caused by how CMAKE_INSTALL_PREFIX is being handled. Without using FORCE because the project ( ) command, whose job is to setup the basic variables needed, will have already set CMAKE_INSTALL_PREFIX. Some older versions of cmake with an incomplete implementation of project don't set the install prefix, allowing this to accidentally work. That is not the intended behavior however, nor does it work with recent versions of cmake. This commit fixes the problem by using the canonical way to handle the CMAKE_INSTALL_PREFIX according to the cmake developers: https://public.kitware.com/pipermail/cmake/2010-December/041135.html
|
Same change for footprint repo: KiCad/kicad-footprints#450 |
|
Following KiCad/kicad-footprints#450 this PR does not solve the issue it intended. I will close the current PR for this reason. If the issue is still present please note it here or open a new issue so that we will keep track of it. |
myfreescalewebpage
added
Abandoned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work for macOS users. It will try to install to /usr/local/share/kicad (which does not exist) and fails without installing anything.
This is caused by how CMAKE_INSTALL_PREFIX is being handled. Without using FORCE because the project ( ) command, whose job is to setup the basic variables needed, will have already set CMAKE_INSTALL_PREFIX. Some older versions of cmake with an incomplete implementation of project don't set the install prefix, allowing this to accidentally work. That is not the intended behavior however, nor does it work with recent versions of cmake.
This commit fixes the problem by using the canonical way to handle the CMAKE_INSTALL_PREFIX according to the cmake developers: https://public.kitware.com/pipermail/cmake/2010-December/041135.html