Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

DSP #9

Merged
merged 14 commits into from
Dec 5, 2017
Merged

DSP #9

merged 14 commits into from
Dec 5, 2017

Conversation

SchrodingersGat
Copy link
Contributor

Transferred DSP_Microchip library

@evanshultz
Copy link
Collaborator

This DSPIC library seems fine, but the check scripts seems to be busted. Also, should dsp.lib/dsp.dcm be brought over here or were you going to do that separately?

- DSP_Freescale
- DSP_Texas
@SchrodingersGat
Copy link
Contributor Author

I am working on the scripts currently. They have never been enabled for this repo :)

Thanks for the hint on dsp.lib - I have added that now too

@SchrodingersGat
Copy link
Contributor Author

Yay scripts are working again (and better than ever!)

@evanshultz
Copy link
Collaborator

@SchrodingersGat Great! There are some ugly issues with missing or wrong default footprints and FPfilters. Do you want to merge as-is or correct those now?

@SchrodingersGat
Copy link
Contributor Author

Please merge as-is and we will raise an issue to fix. Thanks

@SchrodingersGat
Copy link
Contributor Author

@evanshultz @poeschlr bump - ok to merge as is?

@evanshultz
Copy link
Collaborator

@SchrodingersGat Can you fix the conflict?

Do we merge with major errors like this? I will merge, but CvPcb won't work (well). Admittedly, it was already broken so this isn't a regression...

@SchrodingersGat
Copy link
Contributor Author

Yes it will be a lot of work to fix all those. We will create an ongoing issue. As long as we don't make it worse :)

@evanshultz evanshultz merged commit 2bd947b into KiCad:master Dec 5, 2017
@antoniovazquezblanco
Copy link
Collaborator

I use Microchip DSPs and the looks are not consistent between different symbols. Also microchip, depending on the package changes pin numbering so I think it would be a good idea to provide a symbol for each packaging option otherwise users may find problems in the future but this requires a good amount of work I cannot contribute right now.

@SchrodingersGat
Copy link
Contributor Author

@antoniovazquezblanco valid points, there could be a lot of improvements made here

jkriege2 pushed a commit that referenced this pull request Jun 1, 2018
myfreescalewebpage pushed a commit that referenced this pull request Mar 26, 2019
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 28, 2019
myfreescalewebpage pushed a commit that referenced this pull request Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants