Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add TLV755P*DBV LDO aliases #909

Merged
merged 4 commits into from Sep 10, 2018
Merged

Add TLV755P*DBV LDO aliases #909

merged 4 commits into from Sep 10, 2018

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Sep 10, 2018

This adds the TLV755P LDO series SOT23-5/DBV parts from TI as a set of aliases to the TLV71209_SOT23-5 symbol.

Datasheet is http://www.ti.com/lit/ds/symlink/tlv755p.pdf


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@awygle
Copy link
Contributor Author

awygle commented Sep 10, 2018

I don't understand why the Travis script is calculating the center the way it is - based on my other experiences I would expect this to say the component is centered. If someone can offer advice on how to convince Travis I'll make those changes, otherwise I should probably revert the movement (but keep the pin offset change).

@evanshultz evanshultz self-assigned this Sep 10, 2018
@evanshultz
Copy link
Collaborator

In general, the centering algorithm is rather weak (I seem to recall only pin locations are checked) and we often allow violations of this rule. Here is the existing symbol:
image

It's fine as it was. You can revert any movement changes.

And while you're at it: For completeness, can you add Low IQ, Small Size, to the description as in the datasheet title?

Also revert location change (failed attempt to center)
@awygle
Copy link
Contributor Author

awygle commented Sep 10, 2018

Done!

@evanshultz
Copy link
Collaborator

Thanks once again! Please keep the PRs coming!

@evanshultz evanshultz merged commit 3dc9c5f into KiCad:master Sep 10, 2018
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label May 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants