New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix urlbar popup when an IME is invoked #61

Open

beracira wants to merge 1 commit into KiKaraage:main from beracira:main

+53 −41

beracira commented Jun 16, 2024 •

edited

Loading

Fix an issue where when Input Method Editors are invoked, the popup urlbar is dismissed due to breakout-extend attribute no longer being available.

The code changes include:

Update the condition for urlbar popup from breakout-extend to usertyping and focused="true". Note that relying on only usertyping will cause the urlbar to remain in place even when a mouse click is sent.
Fixate padding on various places to accommodate height difference between Latin and CJK characters.
Move popup urlbar shadow to #nav-bar::after, so that elements to the right of urlbar are properly covered.

before.mp4

after.mp4

Tested on Firefox 127.0 (64-bit) on Windows 11 22635.3785


          fix urlbar popup when an IME is invoked

ce71934

beracira marked this pull request as ready for review

June 16, 2024 05:40

beracira mentioned this pull request

fix: transparent url background #64

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment