Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_duplicate_sidecar_error #476

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix_duplicate_sidecar_error #476

merged 1 commit into from
Nov 11, 2021

Conversation

pbajjuri20
Copy link
Contributor

@pbajjuri20 pbajjuri20 commented Nov 11, 2021

kiali/kiali#4387

updated according to this PR.

Applied yaml manually and verified the test case.

apiVersion: networking.istio.io/v1alpha3
kind: Sidecar
metadata:
  name: dupliacate-sidecar1-auto
  namespace: bookinfo
spec:
  egress:
    # If this config is applied, sidecars will only be able to talk to
    # other services in the same namespace, in addition to istio-telemetry
    # and istio-policy
  - hosts:
    - "./*"
    - "istio-system/istio-telemetry.istio-system.svc.cluster.local"
    - "istio-system/istio-policy.istio-system.svc.cluster.local"

sidecar_1

duplicate_sidecar_errors

@ScriptingShrimp
Copy link
Contributor

nice catch!
LGTM

@ScriptingShrimp ScriptingShrimp merged commit 3e1660d into Kiali-QE:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants