Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api change in a minor release #90

Closed
saeed-mosavat opened this issue Dec 14, 2019 · 3 comments
Closed

Api change in a minor release #90

saeed-mosavat opened this issue Dec 14, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@saeed-mosavat
Copy link

Describe the bug
My code was broken after running a yarn install on a different machine.
The input of locale utilities has been changed (from true/false to 'fa'/'en') since v1.1.0 and this utitlity was exported in the index file. So I think this is an API Change and requires a major version upgrade not a minor one.

Expected behavior
No change in api should be experienced on minor upgrades.
@saeed-mosavat saeed-mosavat added the bug Something isn't working label Dec 14, 2019
@the-dr-lazy
Copy link
Contributor

BREAKING CHANGE caused by 240b4f3

@SidMorad SidMorad mentioned this issue Dec 14, 2019
Closed
@Kiarash-Z
Copy link
Owner

Kiarash-Z commented Dec 15, 2019 •
edited
Loading

Hi @saeed-mosavat,I'm sorry about this ❤️. In fact, I just considered the calendar API for such changes(not specifying locale prop for Calendar or DatePicker wasn't a breaking change). It never occurred to my mind that utils will have a BREAKING CHANGE. Now we're at 1.1.4, and It doesn't make sense to bump version only for this. I would consider these changes more carefully in the next releases 👾

@the-dr-lazy the-dr-lazy mentioned this issue Dec 17, 2019
Closed
@Kiarash-Z Kiarash-Z mentioned this issue Dec 17, 2019
Merged
@Kiarash-Z
Copy link
Owner

@saeed-mosavat @thebrodmann just released 2.0.0 with no changes because of this👍

@the-dr-lazy the-dr-lazy mentioned this issue Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@saeed-mosavat @Kiarash-Z @the-dr-lazy