Fix bugs in aligning tool #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 84.17% 84.40% +0.23%
==========================================
Files 192 196 +4
Lines 8257 8368 +111
==========================================
+ Hits 6950 7063 +113
+ Misses 1307 1305 -2 ☔ View full report in Codecov by Sentry. |
Previously x and y were overriden in loop: for(const auto& transformation: transformations)
Reason for this was that previous img2.svg when saved as png was scaled to two different sizes depending on used conversion tool. And I could not find the reason for this. Also a few other imprevements were applied: - ImageMagick fails (sometimes) when no NO_AT_BRIDGE=1 is applied - forcing png24 (RGB) for all outputs
Caused by dlib-cuda package not compile properly on Arch
Kicer86
force-pushed
the
alignment_tool_fix
branch
from
99bce9f
to
2b6f0cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.