Great improvement on Tor bootstrap #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irykoon
commented
Jan 19, 2018
irykoon
commented
- Pop up message when /run/tor/control is not found
- Pop up message when Tor controller cookie is not found
- Optimize Tor Bootstrap Status
- Now user will feel smooth switching to Tor Bootstrap Page
- Disable Tor when user cancel Tor bootstrap
- Move DisableNetwork line to 40_anon_connection_wizard.torrc
Also fixed serveral logical bugs.
When user cancel Tor bootstrap, it is reasonable to assume user wants to disable Tor. For example, when users misconfigure the Tor, Tor bootstrap may stuck at a point. After user hit the cancel button, we should not let Tor keep trying to connect to the Tor network with the misconfigured settings.
1. Pop up message when /run/tor/control is not found 2. Pop up message when Tor controller cookie is not found 3. Optimize Tor Bootstrap Status 4. Now user will feel smooth switching to Tor Bootstrap Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.