Map TAG= to bootstrap phase info #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation will mitigate the vuneralbility described in: http://forums.dds6qkxpwdeubwucdiaord2xgbbeyds25rbsgr73tbfpqpt4a6vjwsyd.onion/t/graphical-gui-whonix-setup-wizard-anon-connection-wizard-technical-discussion/650/540 It also prepares the bootstrap phase info for being translated. The Tor-launcher implementation of this can be found here: https://gitweb.torproject.org/tor-launcher.git/plain/README-BOOTSTRAP
When DisableNetwork set to 1, doing systmctl restart tor@defautl.service is not will not be enough to open /vat/run/tor/control. To workaround this, we have to do systemctl reload tor@default.service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation will prepare the bootstrap phase info for being translated.
It will also mitigate the vulnerability described in: http://forums.dds6qkxpwdeubwucdiaord2xgbbeyds25rbsgr73tbfpqpt4a6vjwsyd.onion/t/graphical-gui-whonix-setup-wizard-anon-connection-wizard-technical-discussion/650/540
However, I choose not to prevent the weird
SUMMARY=from showing up when an attacker manipulates bothTAG=andSUMMARY=. Because:What I am wondering is if such an alert should be exposed to daily user. Or should we simply keep it in a log?