Update livecheck.sh to fix Linux 6 loop device false positives #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the way the lsblk output is generated so it can be modified with regular expressions to exclude empty read-write loop devices and strip it down to only the RO output.
The piping introduced and issue that prevented the `if` from picking up the return value of lsblk. Moved the piping out of the if-statement.
Fixed some user errors I made in the last commit. Put variables in quotes so newlines/line breaks are retained.
- Reworked solution to be easier to understand, simpler and more efficient. - Corrected spelling - Added detailed documentation of every step - Split every step into their own line - Added simplified explanation of the RegEx
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
--output ROflag from thelsblkcall so it can be modified with regular expressions to exclude empty read-write loop devices and strip it down to only the RO output.This fixes: https://forums.kicksecure.com/t/livecheck-sh-script-broken-on-bookworm/269