Support core-js@* #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove node_modules/core-js/ from transpile node_modules to support core-js@2
|
This looks good. I'm just wondering, how are you etting core-js@2 alias in your case? I'm asking, because was wondering if the existing line of code should already take care of this? if (filepath.startsWith(config.resolve.alias['core-js'])) return false |
|
@KidkArolis You can see here #64 |
|
OK, got it. Basically, if some npm dependency (AntD) uses core-js directly, jetpack breaks it by aliasing to core-js@2. But if you delete that alias in jetpack.config.js, then build still breaks because of the babel loader config. With this PR - we always exclude core-js, even if the alias is removed. |
|
Released in 0.17.2. Thanks for the contribution. And sorry for slow (no) response to the original issue. |
|
No worries :) Sorry for opening it before trying to fix it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove node_modules/core-js/ from transpile node_modules to support core-js@2