Add functionality to determine which links to intercept #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KwanMan
force-pushed
the
custom-intercept
branch
from
52dd01c
to
668b278
Compare
KwanMan
changed the title
KwanMan
commented
Dec 5, 2017
|
|
||
| function shouldIntercept (url) { |
There was a problem hiding this comment.
So the problem I have is that I use a catch all ('*') route for a 404 not found page, meaning it will always match a route
|
Closing as we're improving the default interceptor to ignore # links and only intercept links that start with /. This means things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.