-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Tasker Integration #20
Conversation
Will create a plugin event in Tasker and allow you to add it as an action inside Tap, Tap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, the only gripe I'd make is that I was going to put the running of a Tasker task under the advanced category, but I'll do that myself after merging
Thanks for your help!
Cool! :) By the way, after I implemented this I was thinking that maybe it could simply always trigger the Tasker event by default (if the user has Tasker installed) because the user already has to explicitly use it as an event in Tasker, so there shouldn't be the need to configure it in 2 places. In this case it could simply trigger in ActionBase with override fun onTrigger() { ActivityConfigTaskerEvent::class.java.requestQuery(context, TaskerEventUpdate()) What do you think? :) |
Yeah that could work too, but my eventual intention is to allow for actions to be able to have gates on them as well, would that code allow different actions to trigger different tasks, or is it meant more as an "Event" trigger in Tasker? |
If there were different actions you could simply have an option in the Tasker configuration activity to allow the user to choose on which event to trigger. Or even have different events for different actions if you only expect to 2-3 actions max so that the plugin activity list would not get too big :) In any case Tap, Tap could always trigger the Tasker event and then it's up to the user to configure the Tasker plugin event in any way they want to (or not configuring it at all), even possibly combining the event with other conditions in Tasker to make it trigger only when they want to. |
By the way, here's a short demo of some stuff you can do with this integration :) https://youtu.be/FHt_aCE3fss |
Thanks for the video, much appreciated. I think I'll have to have a play around with Tasker, but what you suggested seems like a good idea regardless. I'll move the Tasker option to advanced (so that category actually has a use now rather than being a placeholder for, well, Tasker integration), add what you suggested and see what users think of it |
@joaomgcd just a heads up, I pulled and installed a build with the changes but had to clear Tasker's data to make it show up as a plugin, not sure why |
#32 with some more tasker changes |
Hi! Seems like you forgot to show the new actions in the UI under advanced? :) It's still showing in Utilities for me.. Thanks again! |
Yep, looks like that got lost in the rebase somehow. Really need to get a visual merge program on this machine to do it properly... As the crash on older Android also doesn't appear to be fully fixed there'll probably be an alpha 0.2.1 release tomorrow. |
Will create a plugin event in Tasker and allow you to add it as an action inside Tap, Tap.
Hope this helps! :)