fix: race condition with requestManager for tam & prebid bids #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedaviddias
approved these changes
May 5, 2023
thedaviddias
pushed a commit
that referenced
this pull request
May 5, 2023
## [4.2.6](v4.2.5...v4.2.6) (2023-05-05) ### Bug Fixes * race condition with requestManager for tam & prebid bids ([#127](#127)) ([751bf77](751bf77))
|
🎉 This PR is included in version 4.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue when using both Prebid and Amazon TAM (APS) with React Advertising.
When multiple
AdvertisingSlotscall theactivatefunction at the same time to request a new ad, they all use the samerequestManagerobject to keep track of whether the Prebid and APS bids have returned. Because therequestManagervalues are used as conditional to control when an ad gets refreshed, this creates a race condition between the different ad units. The first ad unit to get both bids back gets refreshed/rerendered, the others don't.The fix was to give every new ad request it's own
requestManagerobject, instead of sharing a global object.