Remove min from buckets propType #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: As of Prebid.js 3.0, the ‘min’ parameter is no longer supported in custom granularities. Also note an important idiosyncracy of the way that price ranges are supported: the interval starts at the min value, and the max of one range defines the min of the next range. So if the second interval defines an implicit min of 0.99 and goes to 5 with an increment of 0.05, Prebid.js will generate the values: 0.99, 1.04, 1.09, etc. This implies that ranges should have max values that are really the min value of next range.
kristapsPelna
added a commit
to kristapsPelna/react-advertising
that referenced
this pull request
Nov 9, 2022
PR KijijiCA#72 (KijijiCA#72) broke a test where ``` priceGranularity: { buckets: [{ max: 3, increment: 4 }] } ``` Was left as `expectToPass: false` while in reality it should have been changed to valid or preferably removed since the value is identical to the use case directly above it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html