Fix for #17: Add tests & support for vertical video resolutions + Formatting Fixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertical video resolutions are on the rise and this library was always showing the "highest" value between width and height first. Now it keeps the order in tact and returns whatever height & width was used correctly. Additionally, reordered the input variables to make more sense. This has the input variable order represented correctly in the output string which is always `width x height`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #17
Vertical video resolutions are on the rise and this library was always showing the "highest" value between width and height first. Now it keeps the order in tact and returns whatever height & width was used correctly.
Additionally, reordered the input variables to make more sense. This has the input variable order represented correctly in the output string which is always
width x height.And I added some formatting fixes while checking up on the cli + readme file.