Ignore invalid URLs

Kikobeats · Jul 5, 2018 · 08f8529 · 08f8529
1 parent d2a1993
commit 08f8529
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/__snapshots__/index.js.snap-shot b/__snapshots__/index.js.snap-shot
@@ -632,3 +632,5 @@ exports['${tag} (${attributeName}) 27'] = [
   }
 ]
 
+exports['ignore invalid URLs 1'] = []
+
diff --git a/src/index.js b/src/index.js
@@ -41,12 +41,14 @@ const includes = (collection, fn) => findIndex(collection, fn) !== -1
 
 const getLink = ({ url, el, attribute }) => {
   const attr = get(el, `attribs.${attribute}`, '')
-  return isEmpty(attr)
-    ? null
-    : Object.assign({
-      url: attr,
-      normalizedUrl: getUrl(url, attr)
-    })
+  if (isEmpty(attr)) return null
+
+  try {
+    const normalizedUrl = getUrl(url, attr)
+    return { url: attr, normalizedUrl }
+  } catch (err) {
+    return null
+  }
 }
 
 const getLinksByAttribute = ({ selector, attribute, url, whitelist }) => {

diff --git a/test/index.js b/test/index.js
@@ -60,6 +60,14 @@ describe('html links', () => {
 
       snapshot(getLinks({ html }))
     })
+
+    it('ignore invalid URLs', () => {
+      const html = generateHtml({
+        urls: ['http://']
+      })
+
+      snapshot(getLinks({ html }))
+    })
   })
 
   describe('selectors supported', () => {