Yavorsky chrome to electron #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Kilian awesome, thanks! |
yavorsky
approved these changes
Mar 27, 2017
README.md
Outdated
| @@ -34,6 +34,25 @@ console.log(versions['1.4.11']); | |||
| // returns "53.0.2785.143" | |||
| ``` | |||
|
|
|||
| #### chromiumVersions | |||
| An object with all _major_ Chromium versions as keys and their respective major Electron version as string value. | |||
There was a problem hiding this comment.
Reworded to remove the ambiguity (thanks @paulchaplin!)
| .replace(/,/g, ",\n\t") | ||
| .replace(/{/g, "{\n\t") | ||
| .replace(/}/g, "\n}"); | ||
| const makePrintable = mapping => JSON.stringify(mapping, null, "\t"); |
README.md
Outdated
| @@ -17,7 +17,7 @@ var e2c = require('electron-to-chromium'); | |||
| The Electron-to-Chromium object has 4 properties to use: | |||
|
|
|||
| #### versions | |||
| An object with all _major_ Electron versions as keys and their respective major Chromium version as string value. | |||
| An object of key-value pairs of a _major_ Electron version as the key, and the respective major Chromium version as the value. | |||
There was a problem hiding this comment.
Nit:
An object of key-value pairs with a major Electron version as the key, and the respective major Chromium version as the value.
Or even more succinctly:
An object mapping a major Electron version to its respective major Chromium version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a chromium-to-electron set of functions, continuing on from #6.
cc @yavorsky