Updating FromScratch to 1.4.0 results in broken icon and error on first start

[nilicule]

Error thrown on first start - after a force quit the application will start normally:

Icon seems broken. Screenshot shows broken icon in Alfred, but Spotlight has the same behaviour:

[Kilian]

Strange. Which version of macos are you using? I'm still on sierra and it works as expected there. Did you overwrite the existing fromscratch,app?

[nilicule]

I'm getting this on 10.13.6, but have a colleague who experienced the same on her 10.13.4 version of macos.

We both chose to overwrite the existing FromScratch app.

[RhythmScout]

I'm seeing the same thing on 10.13.6, but the app will not start after the error dialog is shown (must force quit)

[beauwest]

I am seeing this on 10.13.6 as well. If there's any information or testing you need @Kilian, let me know.

[meyerweb]

I’m seeing very similar behavior on MacOS 10.11.6 (El Capitan), except the JS error is thrown every time I launch, not just on the first. Same or similar icon corruption problem (see top of attached)

[Kilian]

I think I can resolve the icon, but if anyone could test if they get the same error running the app from the repository, that would be great. Installation-instructions are here: https://github.com/Kilian/fromscratch#installation though you should substitute electron main.js with npm start (I will update the readme)

[beauwest]

I just tested and it ran as expected for me through the manual installation and build process. 👍 It does run as Electron with no icon so I can't test that issue, but I assume that's expected.

To clarify too, I was getting the same issues as @meyerweb (Hi Eric, thank you for your many contributions to the industry over the years), where the error was happening every time.

[Kilian]

@beaudesigns it running with the incorrect icon is as expected, since the development process is actually Electron so that's as expected. Not getting an error is too bad, I hoped that would be consistent.

Regardless, could you check https://github.com/Kilian/fromscratch/releases/download/v1.4.1/FromScratch-1.4.1.dmg ? (@nilicule this is new version 1.4.1 from the one in #64, though it has that fix too). For me this fixes the icon, and I hope that it fixes the JS error on load as well, since in this version the only thing vaguely using Path is not executed on mac (because it doesn't have to)

[beauwest]

I had found and tested 1.4.1 earlier today, and I was hitting the same issue that I was with 1.4.0. But, I just downloaded 1.4.1 and tested it again after doing the manual build and it's working now.

Is it possible that something is available on systems that have done the manual build process, that isn't making it into the final build? Just grasping at straws with that.

[Kilian]

Maybe, though I don't really know what! Someone that still has the error, could they send me a screenshot of the /Users/NAME/.fromscratch/ folder? I did some more tracking down and it might be that there is something 'wrong' with that folder.

[Kilian]

Here is a new version of 1.4.1 that outputs the location of the contents file (I now think the error happens when writing the content.txt file).

https://github.com/Kilian/fromscratch/releases/download/v1.4.1/FromScratch-1.4.1-debug.dmg

If someone could install the DMG, and start FromScratch from a terminal using
open /Applications/FromScratch.app/Contents/MacOS/FromScratch

This opens a new terminal window with a printed line
This is what the filepath is: /Users/kilian/.fromscratch/content.txt
I think the last part is wrong for people getting that error, but I need to know how wrong.

It could also be that this version works, since I attempt to resolve the path first.

[beauwest]

This is what the filepath is: /Users/beauwest/.fromscratch/content.txt

This version works for me as well. But the old 1.4.1 was working too.

[badcat]

Running the 1.4.1 debug version under macOS 10.12.6 (Sierra) and still see the intro JS error. The icon is fixed. Cut / Copy / Paste keyboard is working, however the text entry into the app is extremely slow for the text to preview. I tried toggling the theme - same slow. Not sure if this needs an new issue submitted specific to the slowness.

[Kilian]

@badcat what is the output if you run it like I describe in #65 (comment) ?

[badcat]

@Kilian Seems OK, no?
This is what the filepath is: /Users/imacd/.fromscratch/content.txt

[nilicule]

Output is:

➜  ~ /Applications/FromScratch.app/Contents/MacOS/FromScratch ; exit;
This is what the filepath is:  /Users/remco/.fromscratch/content.txt
2018-07-24 08:48:05.126 FromScratch[10102:9527555] *** WARNING: Textured window <AtomNSWindow: 0x7fe423f43640> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.

Note that this version did not give me the error popup and the icon seems fixed in this version as well.

[husainfazel]

Just adding that I'm also receiving a similar error. Subscribing for a resolution.

[Kilian]

Hi everyone,

I have a new debug version available: https://github.com/Kilian/fromscratch/releases/download/v1.4.1/FromScratch-1.4.1-debug2.dmg

If you test this, please back up your .fromscratch folder first

Things to test:

• you don't get the error
• changes you make are still getting saved

This one is kind of 'the nuclear option' since when the error occurs, the code ignores it. I think this will work because I suspect that this error only happens during the application startup due to async weirdness specifically in packaged .app files, but it could mean none of your changes get saved.

[kelp]

I just updated to 1.4.0 and saw the above errors on start. I've updated to the 1.4.1-debug2 version, and am seeing the same issue. If I backup and rename my $HOME/.fromscratch, then FromScratch will start, and it does save new text.

And if I trash the FromScratch app and then start it again, I get the error popup on first start.

However, if I restart FromScratch, it work's on second start.

[Kilian]

So Fromscratch now starts without any errors for you? Could you do a `ls -la` in both folders (old and new .fromscratch folders) and copy the output?

…

On 31 Jul 2018, at 18:38, Travis Cole ***@***.***> wrote: I just updated to 1.4.0 and saw the above errors on start. I've updated to the 1.4.1-debug2 version, and am seeing the same issue. If I backup and rename my $HOME/.fromscratch, then FromScratch will start, and it does save new text. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kelp]

Yeah, it now starts without any error. However, if I reinstall it, it will error on first start.

Here is the output you asked for:

[Kilian]

...I figured it out. 🤕 One of the new command line options we have is --portable, with the alias -p. For some reason, only on first start of an app from /applications, ,-psn_0_1814971 or similar is appended to the launch command, triggering portable mode, which tries to store files adjacent to the application, which it's not allowed to do, causing the error. (The line given in the error is of course something else, which is why it took so long to pinpoint.)

I'm removing the -p alias for now and getting 1.4.1 out for all of you!

[Kilian]

Available here: https://github.com/Kilian/fromscratch/releases/tag/v1.4.1

[husainfazel]

Yes! That fixes the issue on my Mac. Thought you might like to know that there was this minor issue whilst installing:

and is the new UI supposed to look like this:

[Kilian]

Closing this ticket. If anyone else sees the same weirdness as @husainfazel let me know and i'll open a new ticket :)