Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink image matcher interface #18

Closed
KilianB opened this issue Dec 6, 2018 · 2 comments
Closed

Rethink image matcher interface #18

KilianB opened this issue Dec 6, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@KilianB
Copy link
Owner

KilianB commented Dec 6, 2018

We deal with configured image matchers that have a float value associated when adding algorithms (Single Image Matcher , Database Image matcher) and matchers that do not have a preset in the same sense (cumulative image matcher and random forest matchers).

Maybe it's time to refactor the image matchers and introduce a new abstract class in between the interface and the implementations.

also move from float threshold to double precision, This will be yet another breaking change. Bump version to 3.0.0

#16 should be resolved in the same patch if major version is bumped.

@KilianB KilianB added the enhancement New feature or request label Dec 6, 2018
@KilianB
Copy link
Owner Author

KilianB commented Dec 26, 2018

Upgrade to double precision 65188a7

@KilianB
Copy link
Owner Author

KilianB commented Jan 16, 2019

fixed with v 3.0.0

@KilianB KilianB closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant