This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix start cmd for WSL #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming this was derived from the One-click installers section in the readme file in the oobabooga repo, where it states `Run the start_linux.sh, start_windows.bat, start_macos.sh, or start_wsl.bat script depending on your OS.`, the `start_wsl.bat` is actually meant to run from a Windows command prompt or PowerShell. In the context of this ooba implementation, it should just treat WSL as Linux.
|
Thanks @merlinfrombelgium! Great fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Assuming this was derived from the One-click installers section in the readme file in the oobabooga repo, where it states
Run the start_linux.sh, start_windows.bat, start_macos.sh, or start_wsl.bat script depending on your OS., thestart_wsl.batis actually meant to run from a Windows command prompt or PowerShell. In the context of this ooba implementation, it should just treat WSL as Linux.