Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Fixes restart every second message #8

Closed
wants to merge 7 commits into from

Conversation

Notnaton
Copy link
Contributor

This hack makes Ooba restart every second prompt. I removed the else statement to stop it from restarting all the time.

If this is supposed to ensure the model is running it's better to check if the port is open and restart it if it is closed.

@Notnaton
Copy link
Contributor Author

Notnaton commented Oct 22, 2023

Need some feedback on this, I don't understand the problem the hack fixes @KillianLucas

Now it checks if the port is open, if closed it restarts the server.
@KillianLucas
Copy link
Owner

If you've tested it and it works, I'm happy to merge it. It did break on second use for me and required a restart, but that might have been another issue that has since resolved.

Does it work for you if we have it not restart all the time?

@Notnaton
Copy link
Contributor Author

I haven't tested the latest addition properly. It's late now and will do it tomorrow. I'm unsure if we need it at all.

@Notnaton
Copy link
Contributor Author

During first install:
bilde
Connecting to server can timeout, changed sleep(1.5) to sleep(5). from 75s to 250s.
This is due to the --update in update_cmd, I believe.
Should only be a problem if the person has slow internet. Once updated, they can simply re run interpreter and it works.

@KillianLucas Tested

@Notnaton
Copy link
Contributor Author

Notnaton commented Oct 27, 2023

@KillianLucas I have tested it on two other windows systems
using this: pip install git+https://github.com/Notnaton/ooba.git@windows. it contains all 3 patches I made.

@Notnaton Notnaton closed this Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants